Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix access to ECW files with names in UTF-8 #70

Closed
wants to merge 2 commits into from
Closed

Fix access to ECW files with names in UTF-8 #70

wants to merge 2 commits into from

Conversation

drons
Copy link
Contributor

@drons drons commented Oct 8, 2015

Hello!

This update fixes problem with access to ECW files in local encoding when GDAL_FILENAME_IS_UTF8 is set to TRUE.
Bug can be reproduced if we set system encoding different then UTF8 (that is common for Windows)

Im test it with libecw33 & ERDAS_ECW_JPEG2000_SDK_4.3(RW)

@drons
Fix access to ECW files with names in UTF-8
28f183b 
Conflicts:
	gdal/frmts/ecw/ecwdataset.cpp

Conflicts:
	gdal/frmts/ecw/ecwdataset.cpp
@rouault
Copy link
Member

rouault commented Oct 8, 2015

Could you edit your editor settings to use 4 spaces instead of tabulation character for indentation ?

@rouault
Copy link
Member

rouault commented Oct 8, 2015

Note: I'll take care of fixing that for that commit. My remark is for future contriubtions

@drons
Copy link
Contributor Author

drons commented Oct 8, 2015

Ok. No problem

@drons
Copy link
Contributor Author

drons commented Oct 8, 2015

I see needed some additional version checks(

@drons
Copy link
Contributor Author

drons commented Oct 8, 2015

I'm see that needed additional ECW version check.
What version of ECW SDK do you have on Travis?

@rouault
Copy link
Member

rouault commented Oct 8, 2015

Travis has ECW 3.3. I just put the condition ECWSDK_VERSION>=40 in frmts/ecw/ecwcreatecopy.cpp since I only got the error on this. I also conditionnalized on WIN32 the 3 places. Committed in r30911

@rouault rouault closed this Oct 8, 2015
kwrobot pushed a commit to aashish24/gdal-svn that referenced this pull request Oct 8, 2015
ECW: use wide char Open API on Windows when GDAL_FILENAME_IS_UTF8=YES…
9be65e9 
… (patch from drons, OSGeo/gdal#70)

git-svn-id: https://svn.osgeo.org/gdal/trunk/gdal@30911 f0d54148-0727-0410-94bb-9a71ac55c965
@drons
Copy link
Contributor Author

drons commented Oct 8, 2015

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@drons @rouault