Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gdal raster mosaic/stack: turn gdalbuildvrt -strict mode, and add a --resolution=same mode mode #11724

Merged
merged 3 commits into from
Jan 30, 2025
Merged

gdal raster mosaic/stack: turn gdalbuildvrt -strict mode, and add a --resolution=same mode mode #11724

merged 3 commits into from
Jan 30, 2025

Conversation

rouault
Copy link
Member

@rouault rouault commented Jan 27, 2025

  • gdal raster mosaic/stack: add a --resolution=same mode, and default to it
  • gdalbuildvrt: add '-resolution same' mode to check all source rasters have the same resolution
  • gdal raster mosaic/stack: turn gdalbuildvrt -strict mode

Fixes #11717

CC @dbaston

@rouault rouault added funded through GSP Work funded through the GDAL Sponsorship Program gdal_cli Anything related to the new 3.11 "gdal" CLI frontend labels Jan 27, 2025
@rouault rouault added this to the 3.11.0 milestone Jan 27, 2025
@coveralls
Copy link
Collaborator

coveralls commented Jan 27, 2025 •
edited
Loading

Coverage Status

coverage: 70.041% (-0.009%) from 70.05%
when pulling 8e44a03 on rouault:fix_11717
into 5b5adef on OSGeo:master.

dbaston
dbaston approved these changes Jan 29, 2025
View reviewed changes
apps/gdalalg_raster_mosaic.cpp Outdated Show resolved Hide resolved
apps/gdalbuildvrt_lib.cpp
@@ -800,7 +811,8 @@ std::string VRTBuilder::AnalyseRaster(GDALDatasetH hDS,
{
CPLString osExpected = GetProjectionName(pszProjectionRef);
CPLString osGot = GetProjectionName(proj);
return CPLSPrintf("gdalbuildvrt does not support heterogeneous "
return m_osProgramName +
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason to do both string concatenation and printf?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

basically because it is more convenient to write it that way than adding %s and .c_str()

@rouault rouault merged commit 045db42 into OSGeo:master Jan 30, 2025
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbaston dbaston dbaston approved these changes

Assignees
No one assigned
Labels
funded through GSP Work funded through the GDAL Sponsorship Program gdal_cli Anything related to the new 3.11 "gdal" CLI frontend
Projects
None yet
Milestone
3.11.0
3 participants
@rouault @coveralls @dbaston