GDALTermProgress: display estimated remaining time for tasks >= 10 seconds #11152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rouault
added
the
funded through GSP
dbaston
reviewed
Oct 28, 2024
|
|
||
| if (nThisTick <= nLastTick) | ||
| return TRUE; | ||
|
|
||
| const time_t nCurTime = time(nullptr); |
There was a problem hiding this comment.
I guess the "modern" version would be std::chrono::system_clock::now() but any advantage in this case is not not obvious...
|
Some changes suggested at rouault#62 This changes output for me somewhat, e.g. but when the time estimate kicks in, the first part of the line ( |
fixed. I've changed the strategy to output as many |
…conds Refreshed every tick (so 2.5%) (only on interactive terminals. Tested with bash on Linux and cmd on Windows, but should work for all reasonable terminals) ``` Before 5 seconds: 0...10...20... After 5 seconds: 0...10...20...30...40...50 - estimated remaining time: 00:00:07 Upon completion: 0...10...20...30...40...50...60...70...80...90...100 - done in 00:00:13. ``` Fixes OSGeo#11100 Co-authored-by: Daniel Baston <[email protected]>
…le being processed
dbaston
approved these changes
Oct 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refreshed every tick (so 2.5%)
(only on interactive terminals. Tested with bash on Linux and cmd on Windows, but should work for all reasonable terminals)
Fixes #11100