HDF5: add support for libhdf5 >= 1.14.4.2 when built with Float16 #10052
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
13 tasks
|
@rouault , great thanks for this patch. I confirm that GDAL 3.9.0 is building fine (including tests) with HDF5 1.14.4.3 . |
elpaso
reviewed
May 29, 2024
| for (hsize_t i = 0; i < nAttrElmts; i++) | ||
| { | ||
| const uint16_t nVal16 = static_cast<uint16_t *>(buf)[i]; | ||
| const uint32_t nVal32 = CPLHalfToFloat(nVal16); |
There was a problem hiding this comment.
I'm confused by CPLHalfToFloat (which doesn't return a float) and the memcpy below (which assumes sizeof float), I know that they are both 32 bits but I am wondering if that assumption is enforced by standard or if is it "assert"ed somewhere.
There was a problem hiding this comment.
We have a static_assert(sizeof(float) == 4); in port/cpl_conv.cpp
This was referenced Jun 3, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes HDFGroup/hdf5#4527