ERS files with ECW connections in their headers fail to open, due to "Attempt at recursively opening ERS dataset" failure.

[mlittlemore]

Using GDALOpen to load an ERS file.
ERSDataset opens the file then finds that the DataSetType is Translated.
This then calls another GDALOpen within the driver, attempting to open an ECW file.
When checking each driver, looking for the ECW one, it hits the ERS one again which triggers the "Attempt at recursively opening ERS dataset" error.
Then because this is an error, the entire GDALOpen process fails.

I think this would not happen if this recursion check in ERSDataset::Open would occur after the Identify check, so only check for recursion if trying to load an ERS file.

Also this is only happening because the ECW driver is after the ERS driver in the driver list. Not sure if there is a way to change this order.

[rouault]

Please attach a dataset that can be used to reproduce the issue

[mlittlemore]

LandsatImage.zip

[jratike80]

For some reason my gdalinfo knows what to do. Maybe because I have ECW on the top on the format list.

gdalinfo landsat_rgb741_image.ers
Driver: ERS/ERMapper .ers Labelled
Files: landsat_rgb741_image.ers
       landsat_rgb741_image.ecw
Size is 2021, 2265
Coordinate System is:
...

EDIT
Indeed OSGeo4W sets the drivers in different order and I can confirm the error:

gdalinfo landsat_rgb741_image.ers --debug on
GDAL: Auto register C:\OSGeo4W\apps\gdal\lib\gdalplugins\gdal_ECW_JP2ECW.dll using GDALRegister_ECW_JP2ECW.
ERROR 1: Attempt at recursively opening ERS dataset
gdalinfo failed - unable to open 'landsat_rgb741_image.ers'.