Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ogrgeopackagetablelayer.cpp does not compile with SQLite 3.36 #9021

Closed
mpdaly opened this issue Jan 3, 2024 · 0 comments
Closed

ogrgeopackagetablelayer.cpp does not compile with SQLite 3.36 #9021

mpdaly opened this issue Jan 3, 2024 · 0 comments
Assignees
Milestone

Comments

@mpdaly
Copy link
Contributor

mpdaly commented Jan 3, 2024

Expected behavior and actual behavior.

There are six occurences of this block in gdal/ogr/ogrsf_frmts/gpkg/ogrgeopackagetablelayer.cpp:

    const sqlite3_int64 nTotalChangesBefore =
#if SQLITE_VERSION_NUMBER >= 3036000L
        sqlite3_total_changes64(m_poDS->GetDB());
#else
        sqlite3_total_changes(m_poDS->GetDB());
#endif

This should compile with all versions of SQLite, but fails with SQLite 3.36 because sqlite3_total_changes64 was introduced in 3.37, not 3.36. as per the release notes.

Steps to reproduce the problem.

Clone and build with SQLite 3.36

Operating system

All

GDAL version and provenance

master/3.9.0dev (introduced in c4f83c3) and 3.8 (introduced in 8d3050b)

@rouault rouault self-assigned this Jan 3, 2024
@rouault rouault closed this as completed in 4bb78aa Jan 3, 2024
@rouault rouault added this to the 3.8.3 milestone Jan 3, 2024
ralphraul pushed a commit to 1SpatialGroupLtd/gdal that referenced this issue Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants