Optional metadata fields when managing an application #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GufCab
reviewed
Mar 15, 2022
src/app/shared/components/forms/form-body-application/form-body-application.component.html
Show resolved
Hide resolved
src/app/shared/components/metadata-details/metadata-details.component.html
Outdated
Show resolved
Hide resolved
|
Fixes have been applied. This cannot be merged until the related backend PR is approved. |
GufCab
approved these changes
Mar 16, 2022
…tion-metadata # Conflicts: # src/assets/i18n/da.json
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds optional metadata fields on the create and update application page. For now, none of the fields affect any of the pre-existing logic.
A new device type, "Other", has been added. To not confuse it with a real device type, a distinction is made between application device types (the new metadata field) and IoT device types (HTTP, LoRaWAN, Sigfox).
Related PR