FIWARE datatarget #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#54) * Added message to prompt when attempting to delete application with existing devices. Cleaned code in a few files. * Removed debugging print lines and fixed indentation.
GufCab
requested changes
Feb 15, 2022
src/app/applications/datatarget/datatarget-detail/datatarget-detail.component.html
Show resolved
Hide resolved
|
|
||
| viewContainerRef.clear(); | ||
| const factory = this.componentFactoryResolver.resolveComponentFactory(componentType); | ||
| const componentRef = viewContainerRef.createComponent<DatatargetDetail>(factory) |
There was a problem hiding this comment.
Missing Semicolon (and unused componentref)
| type: DataTargetType.FIWARE, | ||
| icon: "/assets/images/logo_FIWARE.png", | ||
| description: "En integration til FIWARE Context Broker" , | ||
| readMoreUrl: "https://www.kmd.dk", |
There was a problem hiding this comment.
Your choice, but consider adding a more specific read-more link :)
src/app/applications/datatarget/datatarget-types-service.service.ts
Outdated
Show resolved
Hide resolved
src/app/applications/datatarget/datatarget-types-service.service.ts
Outdated
Show resolved
Hide resolved
src/app/applications/datatarget/datatarget-types-service.service.ts
Outdated
Show resolved
Hide resolved
src/app/applications/datatarget/fiware/fiware-detail/fiware-detail.component.ts
Outdated
Show resolved
Hide resolved
|
We have resolved most of the comments and run the linter on the new code as requested. The |
GufCab
approved these changes
Feb 17, 2022
GufCab
added a commit
that referenced
this pull request
Feb 23, 2022
* Added message to prompt when attempting to delete application with SigFox device * Added message and functionality to check and to prompt when attempting to delete application with SigFox device * Made the first additions to multicast in frontend. Will try to connect to backend next. * Minor changes to make it work with backend. * PR Changes. Also made the check for sigfox devices in detail page, which i missed before. * Minor changes so detail page will show how updated/created the multicast * PR Changes + formatting * Moved two buttons, multicast and datatargets, to a tab bar in application details. * minor typo fix * Finalized CRUD in frontend. Removed list maps from datatarget and multicast because of change in requirements - now the multicast and datatarget is in a tab bar in the application detail page. * Init api key menu item * changed division in db so the frontend will receive a different promise. Mostly just changed property names because of this change. * First additions to "add device to multicast". A dropdown is made with all the possible sensors for the application, and the chosen ones is sent to backend. * Made frontend functionality so you can add devices to a multicast when you update or create. These devices is then shown in detail page. * made snack for fail to load on multicast edit page * Show api keys * removed 2 console logs * Api key management works * Cleanup after api key * Message to multicast. Made the form and service operations to send to backend, which will then handle the request to chirpstack * Changed details page. Not splitted up in basic details, and lorawan details. * PR changes plus search function for devices in multicast * PR changes - fixed pagination for multicast * Minor snack changes and check if devices is included before sending downlink * PR Changes * merge conflicting * Cleanup * Remove unique permissions pipe * API key cleanup * Fix sigfox group id * Add edit api key * Edit API key PR * Spell organization with "z" * Multicast text description changes * Fixed deleted word "adressen" in multicast creation. Is added again. * Moved hint description under the input form instead of before det input form. Matches the design of the rest of the document. * FIWARE datatarget (#67) * Datatarget multi-types administration and new FIWARE Datatarget type * PR fixes * DatatargetTypesService pr fixes * Optimize bulk import and the load on chirpstack (#65) * Batch bulk import create. Update missing * Reworked update many and cleanup * Comment on bulk import * Added device model error codes Co-authored-by: nlg <[email protected]> Co-authored-by: August Andersen <[email protected]> Co-authored-by: Aram Al-Sabti <[email protected]> Co-authored-by: augusthjerrild <[email protected]> Co-authored-by: AramAlsabti <[email protected]> Co-authored-by: Bartek <[email protected]> Co-authored-by: nlg <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR extends the administration of datatarget with:
Those changes require an updated backend. The PR to the backend repository: OS2iot/OS2iot-backend#141