-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/iot 16 multicast frontend #60
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t to backend next.
…ticast because of change in requirements - now the multicast and datatarget is in a tab bar in the application detail page.
…se. Mostly just changed property names because of this change.
… all the possible sensors for the application, and the chosen ones is sent to backend.
…n you update or create. These devices is then shown in detail page.
… backend, which will then handle the request to chirpstack
AramAlsabti
suggested changes
Dec 9, 2021
src/app/applications/application-detail/application-detail.component.html
Outdated
Show resolved
Hide resolved
src/app/applications/multicast/multicast-edit/multicast-edit.component.html
Show resolved
Hide resolved
src/app/applications/multicast/multicast-edit/multicast-edit.component.html
Show resolved
Hide resolved
AramAlsabti
suggested changes
Dec 9, 2021
src/app/applications/application-detail/application-detail.component.ts
Outdated
Show resolved
Hide resolved
src/app/applications/multicast/multicast-detail/multicast-detail.component.ts
Outdated
Show resolved
Hide resolved
src/app/applications/multicast/multicast-table/multicast-table.component.ts
Outdated
Show resolved
Hide resolved
src/app/applications/multicast/multicast-table/multicast-table.component.ts
Outdated
Show resolved
Hide resolved
src/app/applications/multicast/multicast-table/multicast-table.component.ts
Outdated
Show resolved
Hide resolved
src/app/applications/multicast/multicast-table/multicast-table.component.ts
Outdated
Show resolved
Hide resolved
AramAlsabti
reviewed
Dec 9, 2021
AramAlsabti
reviewed
Dec 9, 2021
src/app/applications/multicast/multicast-detail/multicast-detail.component.ts
Outdated
Show resolved
Hide resolved
AramAlsabti
reviewed
Dec 9, 2021
src/app/applications/multicast/multicast-detail/multicast-detail.component.ts
Outdated
Show resolved
Hide resolved
AramAlsabti
reviewed
Dec 9, 2021
src/app/applications/multicast/multicast-detail/multicast-detail.component.ts
Outdated
Show resolved
Hide resolved
AramAlsabti
reviewed
Dec 9, 2021
src/app/applications/multicast/multicast-edit/multicast-edit.component.ts
Outdated
Show resolved
Hide resolved
AramAlsabti
reviewed
Dec 9, 2021
src/app/applications/multicast/multicast-edit/multicast-edit.component.ts
Outdated
Show resolved
Hide resolved
AramAlsabti
reviewed
Dec 9, 2021
src/app/applications/multicast/multicast-edit/multicast-edit.component.ts
Outdated
Show resolved
Hide resolved
AramAlsabti
reviewed
Dec 9, 2021
src/app/applications/multicast/multicast-edit/multicast-edit.component.ts
Outdated
Show resolved
Hide resolved
AramAlsabti
reviewed
Dec 9, 2021
AramAlsabti
reviewed
Dec 9, 2021
src/app/applications/multicast/multicast-table/multicast-table.component.ts
Outdated
Show resolved
Hide resolved
AramAlsabti
reviewed
Dec 9, 2021
AramAlsabti
reviewed
Dec 9, 2021
AramAlsabti
reviewed
Dec 9, 2021
AramAlsabti
reviewed
Dec 9, 2021
AramAlsabti
suggested changes
Dec 9, 2021
AramAlsabti
approved these changes
Dec 22, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pretty great! PR approved once the feedback is fixed
src/app/applications/multicast/multicast-edit/multicast-edit.component.ts
Outdated
Show resolved
Hide resolved
src/app/applications/multicast/multicast-edit/multicast-edit.component.ts
Show resolved
Hide resolved
src/app/applications/multicast/multicast-table/multicast-table.component.ts
Outdated
Show resolved
Hide resolved
# Conflicts: # src/app/applications/application-detail/application-detail.component.ts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Multicast frontend. Make the multicast, add devices, send messages.