Feature/iot 126 konfiguration af chirpstack service profiles #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 11 commits
August 25, 2020 13:44
…k-Service-profiles
…files' into develop # Conflicts: # package-lock.json # src/app/app-routing.module.ts # src/app/app.module.ts # src/app/my-applications/applications-table/applications-table-row/applications-table-row.component.html # src/app/my-applications/applications-table/applications-table.component.html # src/app/my-applications/create-application/create-application.component.html # src/app/navbar/navbar.component.html # src/app/profiles/service-profiles/service-profiles-list/service-profile-item/service-profile-item.component.spec.ts # src/app/shared/form/form-body-application/form-body-application.component.ts # src/app/shared/form/form-body-iot-devices/form-body-iot-devices.component.ts # src/app/shared/services/chirpstack-gateway.service.ts # src/app/shared/services/chripstack-gateway.service.spec.ts # src/app/shared/services/datatarget.service.spec.ts # src/app/shared/services/datatarget.service.ts # src/app/shared/top-bar/top-bar.component.ts # src/assets/i18n/da.json
ghost
requested a review
from 
ncjej
reviewed
Sep 4, 2020
| import { ProfilesListComponent } from './profiles-list/profiles-list.component'; | ||
|
|
||
|
|
||
| const routes: Routes = [ |
There was a problem hiding this comment.
Hvorfor laver vi vores egen routes til dette modul?
There was a problem hiding this comment.
Til at gøre den klar til Lazy loading....
ncjej
approved these changes
Sep 4, 2020
| return serviceProfileState.serviceProfiles; | ||
| }), | ||
| switchMap(serviceProfiles => { | ||
| if (serviceProfiles.length === 0) { |
There was a problem hiding this comment.
Man kunne overvejer at lave dem statisk når de allievel bare returnere en værdi
| constructor(public payload: ServiceProfile[]) { } | ||
| } | ||
|
|
||
| export class FetchServiceProfiles implements Action { |
| export const DELETE_SERVICEPROFILE = '[Service Profile] Delete Service Profile'; | ||
| export const STORE_SERVICEPROFILES = '[Service Profile] Store Service Profiles'; | ||
|
|
||
| export class SetServiceProfiles implements Action { |
There was a problem hiding this comment.
Jeg er generelt modstander af at have flere classes i samme fil.
There was a problem hiding this comment.
Du har ret... jeg tror jeg ændrer det til den syntax, som de ngrx introducerede for 2 år siden
ncjej
deleted the
feature/IOT-126-Konfiguration-af-Chirpstack-Service-profiles
branch
AramAlsabti
pushed a commit
that referenced
this pull request
Nov 5, 2021
* IOT-5: Add IoTDevice API and Generic HTTP devices * IOT-5: E2E tests for IoTDevice API * fixed error when searching trying to delete application by invalid ID Co-authored-by: Troels Beck Krøgh <[email protected]> Co-authored-by: Thomas Rohleder <[email protected]>
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.