Updated Chirpstack from V3 to V4 #152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…operly from gateway fetches
… on iot-device table
…ation on gateway-status-table
…umn-administration-on-gateway-table
# Conflicts: # src/app/gateway/gateway-edit/gateway-edit.component.html # src/app/gateway/gateway-edit/gateway-edit.component.ts # src/app/gateway/gateway-table/gateway-table.component.ts
fcv-iteratorIt
requested changes
Dec 13, 2023
src/app/profiles/device-profiles/device-profiles-list/device-profiles-list.component.ts
Outdated
Show resolved
Hide resolved
src/app/profiles/device-profiles/device-profiles-list/device-profiles-list.component.ts
Outdated
Show resolved
Hide resolved
src/app/profiles/device-profiles/device-profiles-list/device-profiles-list.component.ts
Outdated
Show resolved
Hide resolved
added 3 commits
December 14, 2023 23:13
…' into feature/IOT-1436-chirpstack-upgrade # Conflicts: # src/app/gateway/gateway-detail/gateway-detail.component.ts # src/app/gateway/gateway-edit/gateway-edit.component.html # src/app/gateway/gateway-edit/gateway-edit.component.ts # src/app/gateway/gateway-overview/gateway-tabs/gateway-map/gateway-map.component.ts # src/app/gateway/gateway-table/gateway-table.component.html # src/app/gateway/gateway-table/gateway-table.component.ts # src/app/gateway/gateway.model.ts # src/app/shared/services/chirpstack-gateway.service.ts
…end (both are nodejs, so shouldn't it be the same?)
added 2 commits
December 15, 2023 09:15
…' into feature/IOT-1436-chirpstack-upgrade # Conflicts: # package-lock.json
fcv-iteratorIt
approved these changes
Dec 15, 2023
| @@ -113,7 +185,7 @@ export class GatewayTableComponent implements AfterViewInit, OnDestroy { | |||
|
|
|||
| lastActive(gateway: Gateway): string { | |||
| if (gateway?.lastSeenAt) { | |||
| const date = gateway.lastSeenAt ?? convertToDateFromTimestamp(gateway.lastSeenAt); | |||
| const date = gateway.lastSeenAt ?? gateway.lastSeenAt | |||
| this.errorMessages = 'Internal server error'; | ||
| return; | ||
| deleteDeviceProfile(id: string) { | ||
| if (id) { |
There was a problem hiding this comment.
For later: fix the formatting of this function. This is peak HADOUKEN indentation
There was a problem hiding this comment.
Nvm I couldn't stand it and fixed it now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ServiceProfile and networkserver is removed from V4.