Allow null numbers and validate them correctly #182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GufCab
requested changes
Jun 8, 2022
|
To keep the changes low-impact, I've moved the changes to the list applications dto and re-defined |
GufCab
approved these changes
Jun 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a supplementary fix to this PR.
The issue with the
class-transformerlibrary is that it mutates the parameter deeply inside a private property. We need to default its value if none is passed; otherwise. it must be validated and sanitized.In cases with editing a payload decoder, we want to fetch all applications. This PR updates the check by allowing null or "null" values, if it has been explicitly allowed. If it's allowed, then the decorator doesn't force it to a number if
nullor "null" is passed.