Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deep-worktype-menu #2435

Merged
merged 2 commits into from
Jan 3, 2025
Merged

deep-worktype-menu #2435

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
66643f8
deep-worktype-menu
leomendoza123 Jan 3, 2025
4ad5c87
Merge branch 'main' into lmendoza/deep-worktype-menu
leomendoza123 Jan 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/app/record/components/work-form/work-form/work-type-menu.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -285,7 +285,10 @@ export const WorkTypeMenu: DeepSelectMenu[] = [
description: $localize`:@@works.teachingDescription:Working with students`,
content: [
// No value for: Lecture ??
/// No value for: Teaching material ??
{
value: WorkTypes.learningObject,
label: WorkTypesLabels[WorkTypes.learningObject],
},
{
value: WorkTypes.supervisedStudentPublication,
label: WorkTypesLabels[WorkTypes.supervisedStudentPublication],
Expand Down
2 changes: 1 addition & 1 deletion src/app/types/works.endpoint.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,7 +143,7 @@ export const WorkTypesLabels = {
[WorkTypes.conferenceProceedings]: $localize`:@@works.conferenceProceedings:Conference proceedings`,
[WorkTypes.design]: $localize`:@@works.design:Design`,
[WorkTypes.image]: $localize`:@@works.image:Image`,
[WorkTypes.learningObject]: $localize`:@@works.learningObject:Learning object`,
[WorkTypes.learningObject]: $localize`:@@works.learningObject:Teaching material`,
[WorkTypes.movingImage]: $localize`:@@works.movingImage:Moving image or video`,
[WorkTypes.musicalComposition]: $localize`:@@works.musicalComposition:Musical composition`,
[WorkTypes.sound]: $localize`:@@works.sound:Sound`,
Expand Down
2 changes: 1 addition & 1 deletion src/locale/properties/works/works.en.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -269,7 +269,6 @@ works.conferencePresentation=Conference presentation
works.conferenceProceedings=Conference proceedings
works.design=Design
works.image=Image
works.learningObject=Learning object
works.movingImage=Moving image or video
works.musicalComposition=Musical composition
works.sound=Sound
Expand All @@ -278,3 +277,4 @@ works.dissemination=Dissemination
works.academicPublication=Academic publications
works.reviewAndEditing=Review and editing
works.pleaseSelectWork=Please select a work type
works.learningObject=Teaching material
Loading