Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OAI-Sets konfigurier- und erweiterbar machen #769

Closed
j3nsch opened this issue Aug 22, 2022 · 1 comment
Closed

OAI-Sets konfigurier- und erweiterbar machen #769

j3nsch opened this issue Aug 22, 2022 · 1 comment
Assignees
@haogatyp

Comments

@j3nsch
Copy link
Member

j3nsch commented Aug 22, 2022

Momentan sind die unterstützten OAI-Sets im Code fest verdrahtet. Durch die Änderungen soll es möglich werden neue OAI-Sets zu implementieren bzw. zu konfigurieren, die von unterschiedlichen Kriterien abhängen. Parallel zum Set für "BelongsToBibliography" soll es einen neuen Set "open_access" geben, der nicht auf eine Sammlung, sondern einem Flag basiert. Andere neue Sets könnten anhand von Enrichments befühlt werden.

In diesem Ticket geht es darum den Code so vorzubereiten, dass ein neuer Set-Typ hinzugefügt werden kann ohne den existierenden Code ändern zu müssen.

Benötigt wird als eine Klasse für OAI-Sets und Implementationen für die bereits existierenden Typen. Die Klasse muss in der Lage sein die Dokumente für einen Set zu lieferen und auch ListSets-Anfragen zu beantworten.
@haogatyp haogatyp self-assigned this Aug 17, 2023
@alw-bsz alw-bsz mentioned this issue Oct 10, 2023
Closed
haogatyp added a commit that referenced this issue Oct 20, 2023
@haogatyp
#769 Moved set functionality to separate set type classes.
c302a35
haogatyp added a commit that referenced this issue Oct 20, 2023
@haogatyp
#769 Capitalize subdirectories.
31d2509
haogatyp added a commit that referenced this issue Oct 23, 2023
@haogatyp
#769 Simplify set query in DocumentList.
929af06
j3nsch added a commit that referenced this issue Oct 23, 2023
@j3nsch
#769 Merged changes from v4.8.1
864e364
j3nsch added a commit that referenced this issue Oct 24, 2023
@j3nsch
#769 Fixed coding style
70c7ccb
haogatyp added a commit that referenced this issue Oct 24, 2023
@haogatyp
#769 Removed hard coded use of set types in DefaultServer::createXmlR…
e1d0256 
…ecord().
haogatyp added a commit that referenced this issue Oct 25, 2023
@haogatyp
#769 Fix coding style.
bc8e00c
haogatyp added a commit that referenced this issue Oct 25, 2023
@haogatyp
#769 Restore behavior in case of sets with more than 2 parts.
f5ec39c
haogatyp added a commit that referenced this issue Oct 26, 2023
@haogatyp
#769 Fix collection type support method.
259238f
haogatyp added a commit that referenced this issue Nov 3, 2023
@haogatyp
#769 Simplified support method of CollectionTypeSets.
62614ae
haogatyp added a commit that referenced this issue Nov 3, 2023
@haogatyp
#769 Added some basic tests for the set type classes.
676546a
haogatyp added a commit that referenced this issue Nov 3, 2023
@haogatyp
#769 Added some basic tests for the SetsManager.
32f5d90
haogatyp added a commit that referenced this issue Nov 6, 2023
@haogatyp
#769 Rename oai server class directories.
923db15
@j3nsch j3nsch mentioned this issue Nov 7, 2023
Closed
haogatyp added a commit that referenced this issue Nov 9, 2023
@haogatyp
#769 Moved set name validation and full set name generation to Oai_Mo…
688e50f 
…del_Set_SetName.
haogatyp added a commit that referenced this issue Nov 9, 2023
@haogatyp
#769 Adjust comment.
90af5d8
@j3nsch j3nsch added this to OPUS 4.8.1 Nov 9, 2023
haogatyp added a commit that referenced this issue Nov 10, 2023
@haogatyp
#769 Mark getSets tests as incomplete.
081529e
haogatyp added a commit that referenced this issue Nov 10, 2023
@haogatyp
#769 Added dummy tests for configureFinder() method marked as incompl…
858d4dd 
…ete.
haogatyp added a commit that referenced this issue Nov 10, 2023
@haogatyp
#769 Added some basic tests for SetName class.
cebfd5d
haogatyp added a commit that referenced this issue Nov 10, 2023
@haogatyp
#769 Adjust supports function for CollectionSets.
2fb13df
j3nsch added a commit that referenced this issue Nov 23, 2023
@j3nsch
#769 Coding style
bc3e088
@j3nsch
Copy link
Member Author

j3nsch commented Jun 4, 2024

Die OAI-Sets werden jetzt durch separate Klassen umgesetzt, die in der Konfiguration hinzugefügt oder entfernt werden können. Das System kann in Zukunft sicherlich noch weiter verbessert werden, funktioniert aber erst einmal.

@j3nsch j3nsch closed this as completed Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@haogatyp haogatyp

Labels
None yet
Projects
OAI-Implementation für Erweiterbarkeit überarbeiten
Status: Done
OPUS 4.8.1
Status: Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@j3nsch @haogatyp