Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modularisierung der OAI Formate ermöglichen #766

Open
j3nsch opened this issue Aug 22, 2022 · 1 comment
Open

Modularisierung der OAI Formate ermöglichen #766

j3nsch opened this issue Aug 22, 2022 · 1 comment
Assignees
@haogatyp

Comments

@j3nsch
Copy link
Member

j3nsch commented Aug 22, 2022 •
edited
Loading

Momentan sind die OAI Formate voneinander abhängig, sie verwenden gemeinsame XSLT-Dateien und der allgemeine OAI-Code enthält Sonderregelungen für einzelne Formate.

Jedes Format soll, wenn notwendig, eine Basisklasse für die Verarbeitung erweitern, um Sonderregelungen einzupflegen. In der Konfiguration für die unterstützten Formate soll angegeben werden welche Klasse für die Verarbeitung verwendet wird bzw. welche Factory verwendet werde muss, um eine Verarbeitungsklasse für das Format zu erhalten.

Die XSLT-Dateien für die einzelnen Formate müssen unabhängig werden. Insbesondere die Datei oai-pmh.xslt wird dadurch dupliziert werden. Dafür wäre es aber möglich Formate als unabhängige Module zu implementieren und wahlweise mit Composer für OPUS 4 zu installieren.

Falls die oai-pmh.xslt OPUS 4 spezifischen Code enthält, der weiter gepflegt werden muss, könnte die Datei durch die Basisimplementation zur Verfügung gestellt werden, zusammen mit einem Weg zur Laufzeit weitere XSLT Datei für das jeweilige Format einzubinden. Die aktuelle Liste mit allen Formaten in dieser Datei muss durch einen dynamischen Mechanismus ersetzt werden.
@j3nsch j3nsch mentioned this issue Jan 25, 2023
Closed
@j3nsch
Copy link
Member Author

j3nsch commented Aug 17, 2023

Dieses Ticket ist eng mit #998, #999 und #1000 verbunden.

haogatyp added a commit that referenced this issue Aug 20, 2023
@haogatyp
#766 Refactor configuration, added options (currently only xslt file…
112b330 
…) for the oai server, added some tests.
haogatyp added a commit that referenced this issue Aug 23, 2023
@haogatyp
#766 Including the prefix xslt in the base xslt instead of the other …
d7e2477 
…way around.
haogatyp added a commit that referenced this issue Aug 25, 2023
@haogatyp
#766 ServerFactory directly reads oai options from configuration and …
83a0a4e 
…injects them into the oai server. XsltFilePath can be absolute and overwritten by a derived server class.
haogatyp added a commit that referenced this issue Aug 25, 2023
@haogatyp
#766 Fix absolut path for xsltFile
84e700e
haogatyp added a commit that referenced this issue Aug 25, 2023
@haogatyp
#766 Fix some coding style.
d0fcdcd
haogatyp added a commit that referenced this issue Aug 30, 2023
@haogatyp
#766 Add basic option getter tests for the BaseServer.
b78a459
haogatyp added a commit that referenced this issue Aug 30, 2023
@haogatyp
#766 Removed usage of getcwd().
e92fc9b
haogatyp added a commit that referenced this issue Aug 30, 2023
@haogatyp
#766 Fix method access level
ce5004d
haogatyp added a commit that referenced this issue Aug 30, 2023
@haogatyp
#766 Split ServerFactory test methods.
4039c6e
haogatyp added a commit that referenced this issue Aug 31, 2023
@haogatyp
#766 Merge default and format specific options.
b167ac2
haogatyp added a commit that referenced this issue Aug 31, 2023
@haogatyp
#766 Remove unnecessary check on "true".
aa07706
haogatyp added a commit that referenced this issue Aug 31, 2023
@haogatyp
#766 Removed throwing the exception, as this is already happening at …
b9585c9 
…the appropriate place and coding style.
haogatyp added a commit that referenced this issue Aug 31, 2023
@haogatyp
#766 Set the value for xsltFile so that it can be overwritten again u…
97311cc 
…sing configuration.
haogatyp added a commit that referenced this issue Sep 1, 2023
@haogatyp
#766 Replaced options array with single properties.
a711037
haogatyp added a commit that referenced this issue Sep 1, 2023
@haogatyp
#766 Replace marker comment with a more technical marker.
88b9275
haogatyp added a commit that referenced this issue Sep 1, 2023
@haogatyp
#766 Removed some double spaces.
2388d8b
haogatyp added a commit that referenced this issue Sep 1, 2023
@haogatyp
#766 Removed some double blank lines.
90b25f2
haogatyp added a commit that referenced this issue Sep 5, 2023
@haogatyp
#766 Remove some hard coded format specific code and reduced oai form…
a84057c 
…at configuration to class definition only.
j3nsch added a commit that referenced this issue Sep 25, 2023
@j3nsch
#766 Added comments to OAI config
c4a8ba6
haogatyp added a commit that referenced this issue Oct 5, 2023
@haogatyp
#766 Rename option "viewHelper"
a8d230c
haogatyp added a commit that referenced this issue Oct 5, 2023
@haogatyp
#766 Fixed some typos.
7967b50
haogatyp added a commit that referenced this issue Oct 5, 2023
@haogatyp
#766 Fix return empty string for integer variables. Renaming maxRecor…
42c37f6 
…ds parameter.
haogatyp added a commit that referenced this issue Oct 5, 2023
@haogatyp
#766 Now also checking for array.
882c038
haogatyp added a commit that referenced this issue Oct 5, 2023
@haogatyp
#766 Using DocumentInterface instead of Document.
8c5cec9
haogatyp added a commit that referenced this issue Oct 5, 2023
@haogatyp
#766 Added class comment.
70b7504
haogatyp added a commit that referenced this issue Oct 6, 2023
@haogatyp
#766 Fix class comment.
e979a6a
haogatyp added a commit that referenced this issue Oct 6, 2023
@haogatyp
#766 Adjust option getters and setters for NULL values.
6f70e08
haogatyp added a commit that referenced this issue Oct 6, 2023
@haogatyp
#766 Using shorter parameter names in setter methods.
b773cf1
haogatyp added a commit that referenced this issue Oct 6, 2023
@haogatyp
#766 Fix some comments.
111b442
haogatyp added a commit that referenced this issue Oct 6, 2023
@haogatyp
#766 Removed unnecessary ternary operator.
c28ecb2
haogatyp added a commit that referenced this issue Oct 6, 2023
@haogatyp
#766 Removed outdated todo comment.
403318e
haogatyp added a commit that referenced this issue Oct 6, 2023
@haogatyp
#766 Renaming the marker for metadata format replacement.
f25c07a
haogatyp added a commit that referenced this issue Oct 6, 2023
@haogatyp
#766 Adjust error message.
d83ab74
haogatyp added a commit that referenced this issue Oct 6, 2023
@haogatyp
#766 Renamed OaiConfig to match the class name.
bc3f3ac
j3nsch added a commit that referenced this issue Oct 9, 2023
@j3nsch
#766 Fixed coding style
e61c90c
j3nsch added a commit that referenced this issue Oct 9, 2023
@j3nsch
#766 Empty line after header (coding style)
f27d9da
haogatyp added a commit that referenced this issue Oct 10, 2023
@haogatyp
#766 Shorten class variable comments.
719d66b
haogatyp added a commit that referenced this issue Oct 10, 2023
@haogatyp
#766 Added a comment to make things hopefully more clear.
bb48b41
haogatyp added a commit that referenced this issue Oct 10, 2023
@haogatyp
#766 Removed unused method.
43072df
haogatyp added a commit that referenced this issue Oct 10, 2023
@haogatyp
#766 Use class name only ones in the function.
1ca259f
haogatyp added a commit that referenced this issue Oct 10, 2023
@haogatyp
#766 Moved oai server test classes to oai test.
01de758
j3nsch added a commit that referenced this issue Oct 10, 2023
@j3nsch
#766 Updated comment
ec8f82d
haogatyp added a commit that referenced this issue Oct 10, 2023
@haogatyp
#766 Removed unnecessary mock test class and moved remaining mock tes…
59b25c3 
…t class back to the support folder.
haogatyp added a commit that referenced this issue Oct 10, 2023
@haogatyp
#766 Added a function to add view helpers to a oai server.
6527e7b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@haogatyp haogatyp

Labels
None yet
Projects
OAI-Implementation für Erweiterbarkeit überarbeiten
Status: No status
Milestone
No milestone
Development

No branches or pull requests
2 participants
@j3nsch @haogatyp