Merge pull request #485 from OPUS4/pubmedurl484

#485 Pubmed base url configurable
OPUS4 · Jan 3, 2022 · 5481024 · 5481024
2 parents 2f7114a + 0c06da0
commit 5481024
Show file tree

Hide file tree

Showing 5 changed files with 29 additions and 3 deletions.
diff --git a/application/configs/application.ini b/application/configs/application.ini
@@ -407,6 +407,9 @@ googleScholar.openInNewWindow = 0
 ; Twitter Settings
 twitter.openInNewWindow = 0
 
+; PubMed Settings
+pubmed.baseUrl = https://pubmed.ncbi.nlm.nih.gov/
+
 ;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;
 ;                                      ;
 ; SWORD related configuration settings ;

diff --git a/modules/export/views/scripts/publist/default.xslt b/modules/export/views/scripts/publist/default.xslt
@@ -572,7 +572,7 @@
        <xsl:if test="@Type='pubmed'">
             <xsl:element name="a">
                 <xsl:attribute name="href">
-                    <xsl:text>http://www.ncbi.nlm.nih.gov/pubmed/</xsl:text>
+                    <xsl:value-of select="php:functionString('Application_Xslt::optionValue', 'baseUrl', 'pubmed')"/>
                     <xsl:value-of select="@Value" />
                 </xsl:attribute>
                 <xsl:text>PMID</xsl:text>

diff --git a/modules/frontdoor/views/scripts/index/templates/metadata.xslt b/modules/frontdoor/views/scripts/index/templates/metadata.xslt
@@ -364,10 +364,10 @@
             <td>
                 <xsl:element name="a">
                     <xsl:attribute name="href">
-                        <xsl:text>http://www.ncbi.nlm.nih.gov/pubmed?term=</xsl:text>
+                        <xsl:value-of select="php:functionString('Application_Xslt::optionValue', 'baseUrl', 'pubmed')"/>
                         <xsl:value-of select="@Value" />
                     </xsl:attribute>
-                    <xsl:text>http://www.ncbi.nlm.nih.gov/pubmed?term=</xsl:text>
+                    <xsl:value-of select="php:functionString('Application_Xslt::optionValue', 'baseUrl', 'pubmed')"/>
                     <xsl:value-of select="@Value" />
                 </xsl:element>
             </td>

diff --git a/tests/modules/export/controllers/IndexControllerTest.php b/tests/modules/export/controllers/IndexControllerTest.php
@@ -1014,4 +1014,13 @@ private function removeAccessOnModuleExportForGuest()
     {
         return $this->removeModuleAccess('export', 'guest');
     }
+
+    public function testPublistPubmedRendering()
+    {
+        $this->dispatch('/export/index/publist/role/publists/number/coll_visible');
+
+        $this->assertResponseCode(200);
+
+        $this->markTestIncomplete('Setup collection for publist including document with pubmed-id');
+    }
 }
diff --git a/tests/modules/frontdoor/controllers/IndexControllerTest.php b/tests/modules/frontdoor/controllers/IndexControllerTest.php
@@ -1545,4 +1545,18 @@ public function testDuplicateDocIdParameter()
         $this->assertXpathContentContains('//h2[@class="titlemain"]', 'KOBV');
         $this->assertNotXpathContentContains('//h2[@class="titlemain"]', 'Sonderzeichen');
     }
+
+    public function testPubmedRendering()
+    {
+        $this->dispatch('/frontdoor/index/index/docId/146');
+
+        $path = 'table.result-data.frontdoordata th.name';
+
+        $config = $this->getConfig();
+
+        $pubmedUrl = $config->pubmed->baseUrl . '123';
+
+        $this->assertQueryContentContains('table.result-data.frontdoordata td', $pubmedUrl);
+        $this->assertXpath("//table/tr/td/a[@href=\"$pubmedUrl\"]");
+    }
 }