Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix invalid caching of color legend textures #12030

Open
magnesj opened this issue Jan 6, 2025 · 0 comments · May be fixed by #12031
Open

Fix invalid caching of color legend textures #12030

magnesj opened this issue Jan 6, 2025 · 0 comments · May be fixed by #12031
Assignees
@magnesj
Labels
BugInRelease Bug in an official release
Milestone
Deeper 2024 - Spr...

Comments

@magnesj
Copy link
Member

magnesj commented Jan 6, 2025

Setting user defined color legend intervals produce wrong visualization in some cases. This is related to caching of effects for geometry parts, and the compare function for TextureImages is inaccurate.

Example of wrong color mapping where values between 10 and 14 should have a different color.

image
@magnesj magnesj added the BugInRelease Bug in an official release label Jan 6, 2025
@magnesj magnesj added this to the Deeper 2024 - Sprint 12 milestone Jan 6, 2025
@magnesj magnesj self-assigned this Jan 6, 2025
magnesj added a commit that referenced this issue Jan 6, 2025
@magnesj
#12030 Fix isEqual for TextureImage
a179785 
When comparing two TextureImages, create a std::vector representation and use the equality operator for std::vector.

Previous implementation did not test all values, and returned equality when the texture was not identical.
@magnesj magnesj linked a pull request Jan 6, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@magnesj magnesj

Labels
BugInRelease Bug in an official release
Projects
None yet
Milestone
Deeper 2024 - Sprint 12
Development

Successfully merging a pull request may close this issue.

Fix isEqual for TextureImage OPM/ResInsight
1 participant
@magnesj