Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhance dmrpp file to support direct chunk IO #809

Merged
merged 7 commits into from
Sep 6, 2023
Merged

Enhance dmrpp file to support direct chunk IO #809

merged 7 commits into from
Sep 6, 2023

Conversation

kyang2014
Copy link
Collaborator

Add deflate_level and filter_mask to the dmrpp file to support the direct chunk IO.

@kyang2014 kyang2014 closed this Aug 31, 2023
@kyang2014 kyang2014 reopened this Sep 1, 2023
@kyang2014 kyang2014 closed this Sep 5, 2023
@kyang2014 kyang2014 reopened this Sep 5, 2023
@sonarqubecloud
Copy link

sonarqubecloud bot commented Sep 5, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

warning The version of Java (11.0.15.1) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

@sonarqubecloud
Copy link

sonarqubecloud bot commented Sep 5, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

warning The version of Java (11.0.15.1) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

@sonarqubecloud
Copy link

sonarqubecloud bot commented Sep 5, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 8 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

warning The version of Java (11.0.15.1) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

@kyang2014 kyang2014 changed the title Enhance dmrpp file to support direct chunk IO - draft Enhance dmrpp file to support direct chunk IO Sep 5, 2023
jgallagher59701
jgallagher59701 reviewed Sep 5, 2023
View reviewed changes
Copy link
Member

@jgallagher59701 jgallagher59701 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question: what happens if there is a Chunk in the DMR++ XML that has compression type "deflate" but no deflateLevel XML attribute?

@kyang2014
Copy link
Collaborator Author

kyang2014 commented Sep 5, 2023 •
edited
Loading

Question: what happens if there is a Chunk in the DMR++ XML that has compression type "deflate" but no deflateLevel XML attribute?

I recollect that I informed you this already. In this case, the vector size of std::vector deflate_levels is 0. No deflate levels can be retrieved.

@jgallagher59701
Copy link
Member

OK, That's good.

jgallagher59701
jgallagher59701 approved these changes Sep 5, 2023
View reviewed changes
Copy link
Member

@jgallagher59701 jgallagher59701 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. Please merge. Thanks.

@kyang2014 kyang2014 merged commit 85b197e into master Sep 6, 2023
@kyang2014 kyang2014 deleted the local_total_storage_size branch September 8, 2023 15:31
@kyang2014 kyang2014 mentioned this pull request Jul 10, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jgallagher59701 jgallagher59701 jgallagher59701 approved these changes

@ndp-opendap ndp-opendap Awaiting requested review from ndp-opendap

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kyang2014 @jgallagher59701