You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I tried wrapping this in ifdefs for HAVE_GDAL, and that helps, but eventually we fail like this:
In file included from DapFunctions.cc:55:
ScaleGrid.h:72:13: error: ‘GDAL_GCP’ was not declared in this scope
72 | std::vector<GDAL_GCP> get_gcp_data(libdap::Array *x, libdap::Array *y, int sample_x = 1, int sample_y = 1);
| ^~~~~~~~
ScaleGrid.h:72:21: error: template argument 1 is invalid
72 | std::vector<GDAL_GCP> get_gcp_data(libdap::Array *x, libdap::Array *y, int sample_x = 1, int sample_y = 1);
| ^
ScaleGrid.h:72:21: error: template argument 2 is invalid
So either more code needs to be protected, or gdal needs to be required, and configure.ac should error out if gdal is not found.
Similarly, if HDF5 is not found, the build proceeds, then errors like this:
The text was updated successfully, but these errors were encountered:
captainkirk99
changed the title
When gdal not present, configure does not complain, but build fails
When gdal not present, configure does not complain, but build fails (same with hdf5)
Dec 5, 2020
Building without gdal, I see that configure.ac correctly determined that gdal was not present:
However, the build then breaks:
This is because DapFunctions includes gdal.h in an unprotected way:
I tried wrapping this in ifdefs for HAVE_GDAL, and that helps, but eventually we fail like this:
So either more code needs to be protected, or gdal needs to be required, and configure.ac should error out if gdal is not found.
Similarly, if HDF5 is not found, the build proceeds, then errors like this:
The text was updated successfully, but these errors were encountered: