Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typos again #2906

Merged
merged 2 commits into from
Dec 20, 2024
Merged

Typos again #2906

merged 2 commits into from
Dec 20, 2024

Conversation

mtx500
Copy link
Contributor

@mtx500 mtx500 commented Dec 12, 2024

Proposed changes

Fixed a lot of typos in comments, strings and local variable names. No API changes.

Related Issues

None.

Types of changes

What types of changes does your code introduce?
Put an x in the boxes that apply. You can also fill these out after creating the PR.

  • Bugfix (non-breaking change which fixes an issue)
  • Enhancement (non-breaking change which adds functionality)
  • Test enhancement (non-breaking change to increase test coverage)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected, requires version increase of Nuget packages)
  • Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc.
  • I have signed the CLA.
  • I ran tests locally with my changes, all passed.
  • I fixed all failing tests in the CI pipelines.
  • I fixed all introduced issues with CodeQL and LGTM.
  • I have added tests that prove my fix is effective or that my feature works and increased code coverage.
  • I have added necessary documentation (if appropriate).
  • Any dependent changes have been merged and published in downstream modules.

Further comments

Copy link

codecov bot commented Dec 12, 2024

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 55.41%. Comparing base (0777bbd) to head (2564984).
Report is 7 commits behind head on master.

Files with missing lines Patch % Lines
...Client.ComplexTypes/DataTypeDefinitionExtension.cs 0.00% 1 Missing ⚠️
...es/Opc.Ua.Security.Certificates/X509Crl/X509Crl.cs 0.00% 1 Missing ⚠️
...Opc.Ua.Core/Types/Schemas/BinarySchemaValidator.cs 0.00% 1 Missing ⚠️
Stack/Opc.Ua.Core/Types/Utils/TypeInfo.cs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2906      +/-   ##
==========================================
- Coverage   55.43%   55.41%   -0.03%     
==========================================
  Files         352      352              
  Lines       67602    67602              
  Branches    13849    13849              
==========================================
- Hits        37477    37460      -17     
- Misses      26021    26042      +21     
+ Partials     4104     4100       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mregen
Copy link
Contributor

mregen commented Dec 19, 2024

due to the amount of conflicts up to @mrsuciu to merge..

@mrsuciu mrsuciu merged commit 57d638e into OPCFoundation:master Dec 20, 2024
75 of 77 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants