1.05.04 final release fixes #2893
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nal-release-fixes
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop/main374 #2893 +/- ##
===================================================
- Coverage 54.96% 54.90% -0.06%
===================================================
Files 349 349
Lines 66354 66639 +285
Branches 13619 13730 +111
===================================================
+ Hits 36470 36588 +118
- Misses 25906 26068 +162
- Partials 3978 3983 +5 ☔ View full report in Codecov by Sentry. |
mregen
approved these changes
Jan 5, 2025
mregen
reviewed
Jan 5, 2025
| @@ -95,6 +95,7 @@ public override void Encode(IEncoder encoder) | |||
| encoder.PushNamespace(XmlNamespace); | |||
|
|
|||
| string fieldName = null; | |||
|
|
|||
| if (encoder.UseReversibleEncoding) | |||
| { | |||
| encoder.WriteUInt32("SwitchField", m_switchField); | |||
There was a problem hiding this comment.
TODO? This implementation doesn't use the new switchfield API yet.
There was a problem hiding this comment.
there is also code which reads the encodingmask
mregen
reviewed
Jan 5, 2025
| @@ -134,6 +134,7 @@ public string PolicyId | |||
| public string DisplayName | |||
| { | |||
| get { return m_displayName; } | |||
| set { m_displayName = value; } | |||
mregen
reviewed
Jan 5, 2025
| @@ -418,6 +418,11 @@ public object Body | |||
| m_encoding = ExtensionObjectEncoding.Xml; | |||
| } | |||
|
|
|||
| else if (m_body is Newtonsoft.Json.Linq.JObject) | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Merges the changes needed for the 1.05.04 release.