Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix serialization of ApplicationConfiguration /CertificateTrustList #2879

Conversation

romanett
Copy link
Contributor

@romanett romanett commented Dec 3, 2024

Proposed changes

Add a KnownType attribute to allow xml serialization of the Type CertificateTrustList contained in the ApplicationConfiguration

Related Issues

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Enhancement (non-breaking change which adds functionality)
  • Test enhancement (non-breaking change to increase test coverage)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected, requires version increase of Nuget packages)
  • Documentation Update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc.
  • I have signed the CLA.
  • I ran tests locally with my changes, all passed.
  • I fixed all failing tests in the CI pipelines.
  • I fixed all introduced issues with CodeQL and LGTM.
  • I have added tests that prove my fix is effective or that my feature works and increased code coverage.
  • I have added necessary documentation (if appropriate).
  • Any dependent changes have been merged and published in downstream modules.

Further comments

@romanett romanett requested a review from mregen December 3, 2024 20:21
@romanett romanett self-assigned this Dec 3, 2024
@romanett romanett added the bug A bug was identified and should be fixed. label Dec 3, 2024
@romanett romanett linked an issue Dec 3, 2024 that may be closed by this pull request
5 tasks
@mregen mregen merged commit 6c62eb2 into OPCFoundation:develop/main374 Dec 4, 2024
48 checks passed
@romanett romanett deleted the fixApplicationConfigurationSerialization branch December 4, 2024 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A bug was identified and should be fixed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ApplicationConfiguration.SaveToFile throws Exception during Serialization
2 participants