Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix TranslateEndpointDescriptions functionality #2495

Merged

Conversation

mrsuciu
Copy link
Contributor

@mrsuciu mrsuciu commented Feb 2, 2024

Proposed changes

Fix TranslateEndpointDescriptions server behaviour when multiple BaseAddresses with different ports exist

Related Issues

  • Fixes #

Types of changes

What types of changes does your code introduce?
Put an x in the boxes that apply. You can also fill these out after creating the PR.

  • Bugfix (non-breaking change which fixes an issue)
  • Enhancement (non-breaking change which adds functionality)
  • Test enhancement (non-breaking change to increase test coverage)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected, requires version increase of Nuget packages)
  • Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc.
  • I have signed the CLA.
  • I ran tests locally with my changes, all passed.
  • I fixed all failing tests in the CI pipelines.
  • I fixed all introduced issues with CodeQL and LGTM.
  • I have added tests that prove my fix is effective or that my feature works and increased code coverage.
  • I have added necessary documentation (if appropriate).
  • Any dependent changes have been merged and published in downstream modules.

Copy link

codecov bot commented Feb 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5afbd81) 52.22% compared to head (8e7a898) 53.83%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2495      +/-   ##
==========================================
+ Coverage   52.22%   53.83%   +1.61%     
==========================================
  Files         316      334      +18     
  Lines       61821    64425    +2604     
  Branches    12726    13226     +500     
==========================================
+ Hits        32284    34685    +2401     
+ Misses      26016    25985      -31     
- Partials     3521     3755     +234     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@mregen mregen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need to document in release notes

// [TestCase("opc.tcp://[fe80:1234::8]:51210/UA/SampleServer", 4)]
// [TestCase("opc.tcp://[fe80:1234::8%3]:51210/UA/SampleServer", 4)]
[TestCase("opc.tcp://[2003:d9:1f0c:5e00:4139:ee31:6cc3:313e]:62541/UA/SampleServer", 6)]
[TestCase("opc.tcp://myhostname.com:51210/UA/SampleServer", 6)]
[TestCase("opc.tcp://UNKNOWNHOSTNAME.COM:51210/UA/SampleServer", 4)]
[TestCase("opc.tcp://EXTERNALHOSTNAME.COM:51210/UA/SampleServer", 6)]
[TestCase("opc.tcp://EXTERNALHOSTNAME.COM:51210/UA/SampleServer", 0)]
[TestCase("opc.tcp://localhost:51210/UA/SampleServer")]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the cases which try to access using a configured AlternateBaseUrl are again failing, because there is no simple way to match them against an internal endpoint. We need to document that alternateBaseUrl with different port always return no matching endpoint, so the configuration should not be used.

@EthanChangAED EthanChangAED added this to the 1.5.373 January Update milestone Feb 6, 2024
@mrsuciu mrsuciu merged commit d573eaa into OPCFoundation:master Feb 6, 2024
45 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants