Add support for ECC profiles #2398
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CertificateIdentifierCollection applicationCertificates,
string pkiRoot = null,
string rejectedRoot = null
)
…plicationCertificateType
mregen
reviewed
Jul 23, 2024
5 tasks
|
code review discussions for follow up
|
VerifySequenceNumber takes policy into account
romanett
requested changes
Sep 30, 2024
| @@ -46,6 +79,7 @@ | |||
| <RejectSHA1SignedCertificates>true</RejectSHA1SignedCertificates> | |||
| <RejectUnknownRevocationStatus>true</RejectUnknownRevocationStatus> | |||
| <MinimumCertificateKeySize>2048</MinimumCertificateKeySize> | |||
| <MinimumECCertificateKeySize>256</MinimumECCertificateKeySize> | |||
Applications/ConsoleReferenceServer/Quickstarts.ReferenceServer.Config.xml
Outdated
Show resolved
Hide resolved
| /// </summary> | ||
| public async Task DeleteApplicationInstanceCertificate(CancellationToken ct = default) | ||
| public async Task DeleteApplicationInstanceCertificate(string[] profileIds = null, CancellationToken ct = default) |
There was a problem hiding this comment.
I oppose extending the interface before supporting only deleting certain profiles
| throw new ServiceResultException(StatusCodes.BadConfigurationError, "The Ecc certificate type is not supported."); | ||
| #else | ||
| ECCurve curve = default(ECCurve); | ||
| if (id.CertificateType == ObjectTypeIds.EccApplicationCertificateType || |
There was a problem hiding this comment.
this code should live in a static function where it is globally accessible
romanett
reviewed
Oct 2, 2024
Libraries/Opc.Ua.Security.Certificates/X509Certificate/X509PfxUtils.cs
Outdated
Show resolved
Hide resolved
|
|
||
| /// <summary> | ||
| /// TODO: Holds the application certificates but should be generated and the Opc.Ua.Security namespace automatically | ||
| /// TODO: Should replace ApplicationCertificateField in the generated Opc.Ua.Security.SecuredApplication class |
There was a problem hiding this comment.
is this needed before merging?
| /// </summary> | ||
| /// <param name="certificate"></param> | ||
| /// <returns></returns> | ||
| public static ECDsa GetPublicKey(X509Certificate2 certificate) |
There was a problem hiding this comment.
Isnt this function also present as non ecc specific variants in another class, if yes i think we can remove it in EccUtils?
| @@ -738,6 +972,12 @@ public Task<X509Certificate2> LoadPrivateKey(string thumbprint, string subjectNa | |||
| return Task.FromResult<X509Certificate2>(null); | |||
| } | |||
|
|
|||
| /// <inheritdoc/> | |||
| public Task<X509Certificate2> LoadPrivateKey(string thumbprint, string subjectName, NodeId certificateType, string password) | |||
…OPCFoundation#2798) The server under test has a extension object with a complex type. Type id = {nsu=http://opcfoundation.org/UA/Machinery/Result/;i=5008}. This contains something with a variant array that is null though (-1). SetProperty should support setting a Array that is null. Therefore, test for null collection (case when length was encoded as -1) before dereferencing ahead of the ToArrray() conversion to Array.
mregen
reviewed
Oct 17, 2024
| <ServerSecurityPolicy> | ||
| <SecurityMode>Sign_2</SecurityMode> | ||
| <SecurityPolicyUri></SecurityPolicyUri> | ||
| </ServerSecurityPolicy> |
There was a problem hiding this comment.
are the default policies populated as per available ECC certificates?
mregen
reviewed
Oct 17, 2024
| <ua:TokenType>UserName_1</ua:TokenType> | ||
| <!-- passwords must be encrypted - this specifies what algorithm to use --> | ||
| <!-- if no algorithm is specified, the active security policy is used --> | ||
| <ua:SecurityPolicyUri>http://opcfoundation.org/UA/SecurityPolicy#Basic256Sha256</ua:SecurityPolicyUri> |
There was a problem hiding this comment.
isn't this now a n invalid configuration if the ECC cert is used?
romanett
approved these changes
Oct 17, 2024
mregen
approved these changes
Oct 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Types of changes
What types of changes does your code introduce?
Put an
xin the boxes that apply. You can also fill these out after creating the PR.Checklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.Further comments