-
Notifications
You must be signed in to change notification settings - Fork 961
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement encoders support for Arrays and multi-dimensional Arrays. #1350
Implement encoders support for Arrays and multi-dimensional Arrays. #1350
Conversation
AlinMoldovean
commented
Apr 2, 2021
•
edited
Loading
edited
- Updates for handling fields with multi-dimensional values. e.g. Complex types with 2D array members are not decoded correctly #920
- JsonEncoder/Decoder fix for non reversible encoding of NodeId, ExpandedNodeId and QualifiedName
This pull request introduces 8 alerts and fixes 2 when merging 58bf1b9 into 1d5e87c - view on LGTM.com new alerts:
fixed alerts:
|
…edNodeId and QualifiedName
This pull request introduces 2 alerts and fixes 2 when merging cfba7ea into 1d5e87c - view on LGTM.com new alerts:
fixed alerts:
|
This pull request fixes 2 alerts when merging 36e4323 into 1d5e87c - view on LGTM.com fixed alerts:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is great... how about few more cases with Json encoder test? How is code coverage for the new code?
The added tests have coverage for new |
This pull request fixes 2 alerts when merging 36bb5bc into 1d5e87c - view on LGTM.com fixed alerts:
|