Fix server time and move all readerwriter locks outside of try/finally #3601
Annotations
11 warnings
|
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
|
|
Build:
Stack/Opc.Ua.Core/Stack/Tcp/UaSCBinaryClientChannel.cs#L656
The behavior of 'string.Format(string, object)' could vary based on the current user's locale settings. Replace this call in 'UaSCUaBinaryClientChannel.ProcessOpenSecureChannelResponse(uint, ArraySegment<byte>)' with a call to 'string.Format(IFormatProvider, string, params object[])'. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1305)
|
|
Build:
Stack/Opc.Ua.Core/Stack/Configuration/SecurityConfigurationManager.cs#L95
Avoid inexact read with 'System.IO.FileStream.Read(byte[], int, int)' (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2022)
|
|
Build:
Stack/Opc.Ua.Core/Stack/Tcp/TcpTransportListener.cs#L419
The behavior of 'Convert.ToUInt32(string)' could vary based on the current user's locale settings. Replace this call in 'TcpTransportListener.UpdateChannelLastActiveTime(string)' with a call to 'Convert.ToUInt32(string, IFormatProvider)'. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1305)
|
|
Build:
Stack/Opc.Ua.Core/Types/Encoders/XmlEncoder.cs#L539
Comparing a span to 'null' might be redundant, the 'null' literal will be implicitly converted to a 'Span<T>.Empty' (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2265)
|
|
Build:
Stack/Opc.Ua.Core/Types/Encoders/BinaryEncoder.cs#L596
Comparing a span to 'null' might be redundant, the 'null' literal will be implicitly converted to a 'Span<T>.Empty' (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2265)
|
|
Build:
Stack/Opc.Ua.Core/Types/Encoders/JsonEncoder.cs#L1084
Comparing a span to 'null' might be redundant, the 'null' literal will be implicitly converted to a 'Span<T>.Empty' (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2265)
|
|
Build:
Tests/Opc.Ua.PubSub.Tests/Transport/MqttPubSubConnectionTests.cs#L82
The behavior of 'string.Format(string, object, object)' could vary based on the current user's locale settings. Replace this call in 'MqttPubSubConnectionTests.ValidateMqttLocalPubSubConnectionWithUadp(object)' with a call to 'string.Format(IFormatProvider, string, params object[])'. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1305)
|
|
Build:
Tests/Opc.Ua.PubSub.Tests/Transport/MqttPubSubConnectionTests.cs#L193
The behavior of 'string.Format(string, object, object)' could vary based on the current user's locale settings. Replace this call in 'MqttPubSubConnectionTests.ValidateMqttLocalPubSubConnectionWithDeltaUadp(object, int)' with a call to 'string.Format(IFormatProvider, string, params object[])'. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1305)
|
|
Build:
Tests/Opc.Ua.PubSub.Tests/Transport/MqttPubSubConnectionTests.cs#L329
The behavior of 'string.Format(string, object, object)' could vary based on the current user's locale settings. Replace this call in 'MqttPubSubConnectionTests.ValidateMqttLocalPubSubConnectionWithJson(object, double)' with a call to 'string.Format(IFormatProvider, string, params object[])'. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1305)
|
|
Build:
Tests/Opc.Ua.PubSub.Tests/Transport/MqttPubSubConnectionTests.cs#L455
The behavior of 'string.Format(string, object, object)' could vary based on the current user's locale settings. Replace this call in 'MqttPubSubConnectionTests.ValidateMqttLocalPubSubConnectionWithDeltaJson(object, int)' with a call to 'string.Format(IFormatProvider, string, params object[])'. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1305)
|
Loading