Use core_mmu_get_va whenever possible #1683
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The changes in plat-hikey are good, but for the others it's actually changed behavior since the result from |
|
Ok. I'll remove the changes for the other plats. Thanks! |
vchong
force-pushed
the
core_mmu_get_va
branch
2 times, most recently
from
fb67617 to
1375de7
Compare
|
Comment addressed. |
|
The commit message could describe the commit a bit more, and also please put a pair of With that: |
|
Commit message updated and tag added. Ready for merge. Thanks! |
The ability to get the va of a pa is now available as a core function, i.e. core_mmu_get_va() so the platform specific nsec_periph_base() is not required anymore. Signed-off-by: Victor Chong <[email protected]> Reviewed-by: Jens Wiklander <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Victor Chong [email protected]