Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optee ftpm: CFG_TA_FTPM_RPMB_STORAGE selects RPMB storage #3

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

etienne-lms
Copy link

Adds configuration switch CFG_TA_FTPM_RPMB_STORAGE that, when enable, makes fTPM OP-TEE TA to explicitly use the eMMC RPMB secure storage of OP-TEE instead of OP-TEE private storage which depends on OP-TEE configuration. The configuration switch is default disabled for compatibility reasons.

Adds configuration switch CFG_TA_FTPM_RPMB_STORAGE that, when enable,
makes fTPM OP-TEE TA to explicitly use the eMMC RPMB secure storage of
OP-TEE instead of OP-TEE private storage which depends on OP-TEE
configuration. The configuration switch is default disabled for
compatibility reasons.

Signed-off-by: Etienne Carriere <[email protected]>
@@ -95,6 +96,8 @@ srcs-y += platform/fTPM_helpers.c

srcs-y += fTPM.c

cflags-$(CFG_TA_FTPM_RPMB_STORAGE) += -DCFG_TA_FTPM_RPMB_STORAGE
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/cflags/cppflags/

@@ -1,4 +1,5 @@
CFG_FTPM_EMULATE_PPI ?= n
CFG_TA_FTPM_RPMB_STORAGE ?= n
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe the configuration should get the storage ID instead of a a boolean value that selects between TEE_STORAGE_PRIVATE and TEE_STORAGE_PRIVATE_RPMB. Here:

CFG_FTPM_TA_TEE_STORAGE_ID ?= TEE_STORAGE_PRIVATE

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants