Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/ted 68 - almost ready notice domain model #7

Merged
merged 18 commits into from
Feb 12, 2022
Merged

Conversation

costezki
Copy link
Collaborator

  • unit tests complete
  • functional tests partially complete but commitable
  • the adoption of TOX for testing
  • fixed notice status transitions
  • polished the Makefile
  • includes pulls from several (parallel) branches

* implemented notice status transition
* implemented notice state updates
* implemented notice status transition
* implemented notice state updates
* implement partially feature tests
* implemented notice status transition
* implemented notice state updates
* implement partially feature tests
@gitguardian
Copy link

gitguardian bot commented Feb 10, 2022

️✅ There are no secrets present in this pull request anymore.

If these secrets were true positive and are still valid, we highly recommend you to revoke them.
Once a secret has been leaked into a git repository, you should consider it compromised, even if it was deleted immediately.
Find here more information about risks.

* implemented notice status transition
* implemented notice state updates
* implement partially feature tests
@codecov
Copy link

codecov bot commented Feb 10, 2022

Codecov Report

Merging #7 (76f9faa) into main (a11b703) will increase coverage by 5.49%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main       #7      +/-   ##
==========================================
+ Coverage   89.76%   95.25%   +5.49%     
==========================================
  Files          19       19              
  Lines         254      295      +41     
==========================================
+ Hits          228      281      +53     
+ Misses         26       14      -12     
Impacted Files Coverage Δ
ted_sws/domain/model/manifestation.py 100.00% <ø> (ø)
ted_sws/domain/model/__init__.py 95.00% <100.00%> (+3.33%) ⬆️
ted_sws/domain/model/metadata.py 100.00% <100.00%> (ø)
ted_sws/domain/model/notice.py 100.00% <100.00%> (+10.29%) ⬆️
ted_sws/notice_fetcher/adapters/ted_api.py 100.00% <100.00%> (+6.81%) ⬆️
ted_sws/notice_fetcher/services/notice_fetcher.py 100.00% <0.00%> (+5.40%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b1784e7...76f9faa. Read the comment docs.

add equality testing for entities
Copy link
Contributor

@kaleanych kaleanych left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I trust the experts! :D

add equality testing for entities
@costezki costezki merged commit bb56b84 into main Feb 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants