Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add date as string field to overcome metabase limitations with docDB #421

Merged
merged 2 commits into from
Jan 11, 2023

Conversation

CaptainOfHacks
Copy link
Contributor

No description provided.

@codecov-commenter
Copy link

Codecov Report

Base: 98.45% // Head: 98.46% // Increases project coverage by +0.01% 🎉

Coverage data is based on head (56c5e1d) compared to base (d75719c).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #421      +/-   ##
==========================================
+ Coverage   98.45%   98.46%   +0.01%     
==========================================
  Files         126      127       +1     
  Lines        6534     6584      +50     
==========================================
+ Hits         6433     6483      +50     
  Misses        101      101              
Impacted Files Coverage Δ
...ices/create_notice_collection_materialised_view.py 100.00% <ø> (ø)
ted_sws/core/model/notice.py 99.49% <100.00%> (ø)
ted_sws/core/model/transform.py 100.00% <100.00%> (ø)
ted_sws/data_manager/adapters/__init__.py 100.00% <100.00%> (ø)
.../data_manager/adapters/mapping_suite_repository.py 100.00% <100.00%> (ø)
ted_sws/data_manager/adapters/notice_repository.py 95.83% <100.00%> (+0.15%) ⬆️
...s/data_manager/adapters/supra_notice_repository.py 100.00% <100.00%> (ø)
...event_manager/adapters/event_logging_repository.py 96.49% <100.00%> (+0.41%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 4 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@CaptainOfHacks CaptainOfHacks merged commit 43990b8 into main Jan 11, 2023
@CaptainOfHacks CaptainOfHacks deleted the feature/TED-1149 branch January 11, 2023 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants