Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make response expiry date mandatory for both launch formats #83

Merged
merged 2 commits into from
May 18, 2023

Conversation

petechd
Copy link
Contributor

@petechd petechd commented May 11, 2023

What is the context of this PR?

This updates both v1 and v2 RM to eQ Runner payload formats and updates response_expires_at property. response_expires_at is required to be a mandatory field sent from RM now and is always validated/doesn't default in eq Runner at launch hence this change.

Links

Check the change is correct and that the updated example schemas pass validation.

Checklist

  • Changes to the spec have been added to example schemas in examples/
  • JSON Schema definitions have been updated

@petechd petechd requested review from a team as code owners May 11, 2023 12:34
@petechd
Copy link
Contributor Author

petechd commented May 11, 2023

Copy link
Contributor

@MebinAbraham MebinAbraham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to update launch_v1.json and launch_v2.json to mark response_expires_at as mandatory. Other than that, LGTM.

Copy link
Contributor

@pricem14pc pricem14pc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For completeness, confirming that response_expires_at is populated with the value of the mandatory event date exercise_end. Collection exercises cannot go live without the business adding this.

@petechd petechd merged commit b863aad into main May 18, 2023
@petechd petechd deleted the make-response-expiry-date-mandatory branch May 18, 2023 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants