Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

420 flag for winsorisation #38

Merged
merged 8 commits into from
Jul 11, 2024
Merged

420 flag for winsorisation #38

merged 8 commits into from
Jul 11, 2024

Conversation

sarahcollyer
Copy link
Collaborator

@sarahcollyer sarahcollyer commented Jun 25, 2024

Summary

Added function to flag rows for winsorisation.
Works by multiplying the a weight and g weight columns together, then flagging any rows where the result is =<1.

Checklists

This pull request meets the following requirements:

  • installable with all dependencies recorded
  • runs without error
  • follows PEP8 and project specific conventions
  • appropriate use of comments, for example no descriptive comments
  • functions documented using Numpy style docstings
  • assumptions and decisions log considered and updated if appropriate
  • unit tests have been updated to cover essential functionality for a reasonable range of inputs and conditions
  • other forms of testing such as end-to-end and user-interface testing have been considered and updated as required
  • tests suite passes (locally as a minimum)
  • peer reviewed with review recorded

If you feel some of these conditions do not apply for this pull request, please
add a comment to explain why.

other forms of testing such as end-to-end and user-interface testing have been considered and updated as required - not considered yet as we have only just begun coding this method

@sarahcollyer
Copy link
Collaborator Author

Have also split test data into flag_data.csv which only contains the columns needed for this function, and predicted_unit_data.csv, which has columns needed for the next function we'll be writing for this method.

@sarahcollyer sarahcollyer requested a review from shilohd June 26, 2024 12:29
Copy link
Collaborator

@shilohd shilohd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@shilohd shilohd merged commit 71a9d56 into main Jul 11, 2024
2 of 3 checks passed
@shilohd shilohd deleted the 420-flag-for-winsorisation branch July 11, 2024 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants