Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

321 flag to ignore response #18

Merged
merged 3 commits into from
Jun 5, 2024
Merged

321 flag to ignore response #18

merged 3 commits into from
Jun 5, 2024

Conversation

AntonZogk
Copy link
Collaborator

Summary

Function to help filtering values which users want to ignore when calculating the links

Checklists

This pull request meets the following requirements:

  • installable with all dependencies recorded
  • runs without error
  • follows PEP8 and project specific conventions
  • appropriate use of comments, for example no descriptive comments
  • functions documented using Numpy style docstings
  • assumptions and decisions log considered and updated if appropriate
  • unit tests have been updated to cover essential functionality for a reasonable range of inputs and conditions
  • other forms of testing such as end-to-end and user-interface testing have been considered and updated as required
  • tests suite passes (locally as a minimum)
  • peer reviewed with review recorded

This a low level function no need to check if it can be install at this point, no dependencies recorded it uses the pandas framework only

AntonZogk added 3 commits May 23, 2024 12:59
The function adds a new column indicating if row should be ignored. It is based on set_index and index comparison.

Added 2 tests, one to check the output, and if exception is raised when columns do not match.
The function adds a new column indicating if row should be ignored. It is based on set_index and index comparison.

Added 2 tests, one to check the output, and if exception is raised when columns do not match.
@AntonZogk AntonZogk added the enhancement New feature or request label May 23, 2024
@robertswh robertswh self-assigned this Jun 5, 2024
Copy link
Collaborator

@robertswh robertswh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code is efficient and the tests are sensible. I agree the TODOs mentioned could be done in future. Happy to merge

@robertswh robertswh merged commit ecca2a4 into main Jun 5, 2024
3 checks passed
@robertswh robertswh deleted the 321-flag-to-ignore-response branch June 5, 2024 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants