Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added testing guide and function tips #17

Merged
merged 2 commits into from
Jun 4, 2024

Conversation

robertswh
Copy link
Collaborator

@robertswh robertswh commented May 21, 2024

Summary

Summarised today's team discussion on testing and functions

Checklists

  • read new sections of CONTRIBUTING.md to ensure they are consistent with discussion at team meeting
  • nothing significant is missing from the guide that was discussed

Copy link
Collaborator

@rowanhemsi rowanhemsi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good summary of our discussion and addition to the contributing guidance.
Left two suggestions on the function section but happy to approve

docs/contributor_guide/CONTRIBUTING.md Outdated Show resolved Hide resolved
@rowanhemsi
Copy link
Collaborator

Just noticed the Check for trailing whitespaces check is failing, please can you install and run the precommit hooks locally or fix the issue manually before merging

@rowanhemsi rowanhemsi merged commit ba25aef into main Jun 4, 2024
3 checks passed
@rowanhemsi rowanhemsi deleted the 367-agree-on-testing-approach branch June 4, 2024 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants