-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
353 create imputation markers #14
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Jday7879 lovely work for a complicated task love what you did with ffil and bffill smart solution :)
I have left some comments, happy to chat in more detail about them
… (can be extracted to yaml file if needed)
Instead of calling flag_matched_pair_merge within the function to create the predictive_auxiliary, it is defined as function argument. Hence flag_matched_pair_merge must be called before create_impute_flags. This will convert flag_matched_pair_merge to a low level function and using pandas framework.
I updated the function . Instead of calling flag_matched_pair_merge within the function to create the predictive_auxiliary, it is defined as function argument. Hence flag_matched_pair_merge must be called before create_impute_flags. This will convert flag_matched_pair_merge to a low level function and using only pandas framework. I added the predictive_auxiliary to test_data csv file and I also updated the tests accordingly to match expected columns |
Ticket needs new review from different developer
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, tests pass.
Summary
Added function which creates a logical column checking if the target variable is a return, or can be imputed by forward or backwards imputation or imputed by construction
Updated original unit tests ready to expand to create a single test dataset, but this should be added to the backlog and looked at further down the line
Checklists
This pull request meets the following requirements:
If you feel some of these conditions do not apply for this pull request, please
add a comment to explain why.