Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify apply_estimation #135

Merged
merged 1 commit into from
Dec 11, 2024
Merged

Modify apply_estimation #135

merged 1 commit into from
Dec 11, 2024

Conversation

Jday7879
Copy link
Collaborator

@Jday7879 Jday7879 commented Dec 10, 2024

Pull Request Title

overwrite config estimation

Summary

  • calibration group mapping now loaded in apply estimation
  • removed overwriting config in estimate
  • calibration_group_map updated to calibration_group_map_path in config

Type of Change

  • Bug fix
  • New feature
  • Breaking change
  • Documentation update
  • Other (please describe):

Checklists

This pull request meets the following requirements:

Creator Checklist

  • Installable with all dependencies recorded
  • Runs without error
  • Follows PEP8 and project-specific conventions
  • Appropriate use of comments, for example, no descriptive comments
  • Functions documented using Numpy style docstrings
  • Assumptions and decisions log considered and updated if appropriate
  • Unit tests have been updated to cover essential functionality for a reasonable range of inputs and conditions
  • Other forms of testing such as end-to-end and user-interface testing have been considered and updated as required

If you feel some of these conditions do not apply for this pull request, please
add a comment to explain why.

Reviewer Checklist

  • Test suite passes (locally as a minimum)
  • Peer reviewed with review recorded

Additional Information

Please provide any additional information or context that would help the reviewer understand the changes in this pull request.

Related Issues

Link any related issues or pull requests here.

@Jday7879 Jday7879 marked this pull request as ready for review December 10, 2024 12:24
- calibration group mapping now loaded in apply estimation
- removed overwriting config in estimate
- calibration_group_map updated to calibration_group_map_path in config
@Jday7879 Jday7879 force-pushed the 653-overwrite-config-estimation branch from 33f1774 to 6c316c0 Compare December 10, 2024 12:28
@Jday7879 Jday7879 requested a review from robertswh December 11, 2024 08:49
Copy link
Collaborator

@robertswh robertswh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes are all good. Questioned whether putting the config read in lower level functions would be better, but Jordan rightly pointed out it's best to read the mapper outside the loop. Happy to merge.

@Jday7879 Jday7879 merged commit e20ba37 into main Dec 11, 2024
5 checks passed
@Jday7879 Jday7879 deleted the 653-overwrite-config-estimation branch December 11, 2024 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants