Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding additional outputs wrapper #126

Merged
merged 3 commits into from
Dec 12, 2024
Merged

Adding additional outputs wrapper #126

merged 3 commits into from
Dec 12, 2024

Conversation

lhubbardONS
Copy link
Collaborator

Adding additional outputs wrapper and making edits to additional outputs scripts to work correctly with wrapper.

Summary

Add your summary here - keep it brief, to the point, and in plain English.

Checklists

This pull request meets the following requirements:

  • installable with all dependencies recorded
  • runs without error
  • follows PEP8 and project specific conventions
  • appropriate use of comments, for example no descriptive comments
  • functions documented using Numpy style docstings
  • assumptions and decisions log considered and updated if appropriate
  • unit tests have been updated to cover essential functionality for a reasonable range of inputs and conditions
  • other forms of testing such as end-to-end and user-interface testing have been considered and updated as required
  • tests suite passes (locally as a minimum)
  • peer reviewed with review recorded

If you feel some of these conditions do not apply for this pull request, please
add a comment to explain why.

@lhubbardONS lhubbardONS marked this pull request as ready for review November 18, 2024 09:41
Copy link
Collaborator

@Jday7879 Jday7879 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good to me, Nice second example showing different input arguments!

@lhubbardONS
Copy link
Collaborator Author

Latest changes are related to ASAP-679

Copy link
Collaborator

@AntonZogk AntonZogk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looking good :)

@lhubbardONS lhubbardONS merged commit 979446d into main Dec 12, 2024
5 checks passed
@lhubbardONS lhubbardONS deleted the 652_outputs_wrapper branch December 12, 2024 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants