Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating PR template #125

Merged
merged 3 commits into from
Nov 22, 2024
Merged

Updating PR template #125

merged 3 commits into from
Nov 22, 2024

Conversation

Jday7879
Copy link
Collaborator

@Jday7879 Jday7879 commented Nov 7, 2024

Pull Request Title

Updating PR template

Summary

Add your summary here - keep it brief, to the point, and in plain English.

Type of Change

  • Bug fix
  • New feature
  • Breaking change
  • Documentation update
  • Other (please describe):

Checklists

This pull request meets the following requirements:

Creator Checklist

  • Installable with all dependencies recorded
  • Runs without error
  • Follows PEP8 and project-specific conventions
  • Appropriate use of comments, for example, no descriptive comments
  • Functions documented using Numpy style docstrings
  • Assumptions and decisions log considered and updated if appropriate
  • Unit tests have been updated to cover essential functionality for a reasonable range of inputs and conditions
  • Other forms of testing such as end-to-end and user-interface testing have been considered and updated as required

If you feel some of these conditions do not apply for this pull request, please
add a comment to explain why.

Reviewer Checklist

  • Test suite passes (locally as a minimum)
  • Peer reviewed with review recorded

Additional Information

Please provide any additional information or context that would help the reviewer understand the changes in this pull request.

Related Issues

Link any related issues or pull requests here.

- include title
- split checklist in two
@Jday7879 Jday7879 marked this pull request as ready for review November 13, 2024 14:28
@Jday7879 Jday7879 closed this Nov 18, 2024
@Jday7879 Jday7879 reopened this Nov 18, 2024
@AntonZogk AntonZogk self-requested a review November 22, 2024 14:18
Copy link
Collaborator

@AntonZogk AntonZogk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looking good

@Jday7879 Jday7879 merged commit 4accbfd into main Nov 22, 2024
5 checks passed
@Jday7879 Jday7879 deleted the 651-pr-template branch November 22, 2024 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants