Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

498 sampled_flag is providing flag for census groups #122

Merged

Conversation

AntonZogk
Copy link
Collaborator

@AntonZogk AntonZogk commented Nov 6, 2024

*Check if calibration group is cencus
*Add unit test, test data
*Remove correct_values function,test,test data
*Implement is_cencus in apply estimation

Summary

Add your summary here - keep it brief, to the point, and in plain English.

Checklists

This pull request meets the following requirements:

  • installable with all dependencies recorded
  • runs without error
  • follows PEP8 and project specific conventions
  • appropriate use of comments, for example no descriptive comments
  • functions documented using Numpy style docstings
  • assumptions and decisions log considered and updated if appropriate
  • unit tests have been updated to cover essential functionality for a reasonable range of inputs and conditions
  • other forms of testing such as end-to-end and user-interface testing have been considered and updated as required
  • tests suite passes (locally as a minimum)
  • peer reviewed with review recorded

If you feel some of these conditions do not apply for this pull request, please
add a comment to explain why.

AntonZogk and others added 5 commits November 6, 2024 14:21
*Check if calibration group is cencus
*Add unit test, test data
*Remove correct_values function,test,test data
*Implement is_cencus in apply estimation
Is essential for the staging to be packaged
Copy link
Collaborator

@robertswh robertswh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could do with a test for apply estimation, I'll add to backlog. There doesn't seem to be an obvious home for the is_census() function, but where it is now is fine. We can re-assess at a later date.

@AntonZogk AntonZogk merged commit a5303b5 into main Nov 7, 2024
5 checks passed
@AntonZogk AntonZogk deleted the 498-sampled-flag-is-providing-flag-for-census-groups branch November 7, 2024 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants