623 ci with cml runtimes #118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Break steps Add 3.11 runtime Change name tags
|
The workflow failed because of : More details in the workflows |
* Creating mapping validation function * Docstrings * Update docstring and leave unmatched as set * Update to raise warning and created wraper to test multiple mapping files in one go * adding test that passes when a warning raised * update docstring to ask that mapping file be a folder and not a file
*Add reusable function *Add test data *Add unit test *Add TODO to use this function in other parts of the pipeline
* move files to correct location * change relevant module imports * Move files to apropiate folders, rename folders * Move all data to equivalent test folder structure * Update estimation test paths and imports * Update imputation test paths and imports * Update outlier detection test paths and imports * Update outpus test paths and imports * Update utilities test paths and imports * Remove tests/imputation/test_pivot_imputation_value.py * Run hooks * Add tests tree into tests readme * Run hooks * Remove duplicated test data * These were copied instead of moved, hence duplicated * these files aren't needed and covered by other tests * update tree --------- Co-authored-by: Wil Roberts <[email protected]>
|
Updated source code for test_data_cleaning -> when selecting column can't use dictionary, by using list(dict) we get a list of the keys Updated tests/utilities/test_constrains.py, there was an issue nan not equal to nan, solved by forcing string dtype instead of object Updated the pre-commit (run pre-comming migrate config as suggested in warnings) used python instead of python3 (python3 was only for cdh) Did a rebase with main to apply all recent changes in structure and build tests against them |
AntonZogk
force-pushed
the
623-CI-with-CML-runtimes
branch
from
8d65839 to
c2e013f
Compare
robertswh
approved these changes
Oct 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Updating workflow to use cml runtimes to build and test the package when a pull request is created
Checklists
This pull request meets the following requirements:
If you feel some of these conditions do not apply for this pull request, please
add a comment to explain why.