478 update main #115
Merged
478 update main #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jday7879
force-pushed
the
478-update-main
branch
from
b408579 to
18fdf94
Compare
Jday7879
force-pushed
the
478-update-main
branch
from
d24a5cc to
e6d86dc
Compare
…when performing joins
…y in contributors
- Keep columns is now a list not dict - Created master dictionary with all column names to avoid overlap in dicts
AntonZogk
reviewed
Nov 5, 2024
mbs_results/staging/dfs_from_spp.py
Outdated
| from rdsa_utils.cdp.helpers.s3_utils import load_json | ||
|
|
||
|
|
||
| def dfs_from_spp( |
There was a problem hiding this comment.
function name should have a verb, read_dfs_from_spp perhaps? or something like this
AntonZogk
reviewed
Nov 5, 2024
| return mapper | ||
|
|
||
|
|
||
| def read_and_combine_colon_sep_files(folder_path, column_names, config): |
AntonZogk
reviewed
Nov 5, 2024
|
|
||
| Returns | ||
| ------- | ||
| _type_ |
AntonZogk
reviewed
Nov 5, 2024
| output_path = config["output_path"] | ||
| file_version_mbs = metadata.metadata("monthly-business-survey-results")["version"] | ||
| snapshot_name = config["mbs_file_name"].split(".")[0] | ||
| imputation_filename = f"imputation_output_v{file_version_mbs}_{snapshot_name}.csv" |
There was a problem hiding this comment.
loved that you have snapshot name
AntonZogk
reviewed
Nov 5, 2024
| warnings.warn("A placeholder function for validating dataframe post staging") | ||
|
|
||
|
|
||
| def validate_imputation(df: pd.DataFrame, config: dict): |
There was a problem hiding this comment.
missing docs in all validation
AntonZogk
reviewed
Nov 5, 2024
mbs_results/estimation/estimate.py
Outdated
| Parameters | ||
| ---------- | ||
| df : pd.DataFrame | ||
| _description_ |
There was a problem hiding this comment.
missing description and types
AntonZogk
requested changes
Nov 5, 2024
There was a problem hiding this comment.
Amazing work some very minor changes in the comments, also might be worth adding a unit testing the run main function, this will guarantee that everything's integrated if the pipeline is extended or updated. We test the methods thoroughly so just a basic integration testing should be fine?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add your summary here - keep it brief, to the point, and in plain English.
Checklists
This pull request meets the following requirements:
If you feel some of these conditions do not apply for this pull request, please
add a comment to explain why.