Feature/remove datasets functionality #1085
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This removes
/datasets
, associated functionality andenableDatasetsImport
Removed the datasets folder from views, only leaving datasets-new, which would be worth renaming to datasets in the future.
The datasets button will always appear in the nav bar. Removed
enableDatasetImport
from legacy so thats the case for them too, and API dataset in the nav.I've replaced
deletePageIncludingDatasetImport
with the defaultdeletePage
but still uses the functionality ofdeletePageIncludingDatasetImport. Sending a delete request to
/zebedee/page/instead of
/zebedee/content/`How to review
dp ssh sandbox publishing 2 -p 23200:localhost:10800
make dev
in florenceRemoved routes:
Example page:
Sense check.
Tests pass.
Did I miss any
/datasets
or enable datasets import functionality.Who can review
Not me