Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/remove datasets functionality #1085

Merged
merged 7 commits into from
Dec 19, 2024

Conversation

StRhys
Copy link
Contributor

@StRhys StRhys commented Dec 18, 2024

What

This removes /datasets, associated functionality and enableDatasetsImport

Removed the datasets folder from views, only leaving datasets-new, which would be worth renaming to datasets in the future.

The datasets button will always appear in the nav bar. Removed enableDatasetImport from legacy so thats the case for them too, and API dataset in the nav.
I've replaced deletePageIncludingDatasetImport with the default deletePage but still uses the functionality of deletePageIncludingDatasetImport. Sending a delete request to /zebedee/page/instead of/zebedee/content/`

How to review

  • port forward to the api router - dp ssh sandbox publishing 2 -p 23200:localhost:10800
  • I was running the home publishing stack
  • make dev in florence

Removed routes:

  • /datasets
  • /datasets/:datasetID
  • /datasets/:datasetID/preview
  • /datasets/:datasetID/metadata
  • /datasets/:datasetID/editions/:edition/versions/:version
  • /datasets/:datasetID/editions/:edition/versions/:version/metadata
  • /datasets/:datasetID/editions/:edition/versions/:version/preview
  • /datasets/:datasetID/instances - ??
  • /datasets/:datasetID/instances/:instanceID/metadata - ??

Example page:

Sense check.
Tests pass.
Did I miss any /datasets or enable datasets import functionality.

Who can review

Not me

@StRhys StRhys requested a review from a team as a code owner December 18, 2024 12:06
@StRhys StRhys merged commit 7c09ba5 into develop Dec 19, 2024
5 checks passed
@StRhys StRhys deleted the feature/remove-datasets-functionality branch December 19, 2024 20:05
This was referenced Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants