Account for topics with no subtopics #1053
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lindenmckenzie
force-pushed
the
fix/check-no-topics
branch
from
7eccf4c to
3a1704b
Compare
lindenmckenzie
force-pushed
the
fix/check-no-topics
branch
from
d558702 to
dbc279a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Add check for if no subtopics (introduced by new parent topics without subtopics)
How to review
Check code good, tests pass.
Optionally:
Run Florence locally with SecAuth on, port forward to api router in sandbox.
Create collection, edit bulletin page (or other with tags). Observe tagging now works appropriately.
Who can review
Florence dev.