Update GitHub Actions for keyless auth GAR push #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rmccar
reviewed
Sep 3, 2024
Co-authored-by: rmccar <[email protected]>
berroar
approved these changes
Sep 3, 2024
petechd
approved these changes
Sep 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the context of this PR?
We need to move to keyless authentication to allow pushing of our Docker images from our PR branches.
How to review
Ensure that the GitHub action passes for this PR and the image is pushed successfully. NOTE - This PR build will fail until the keyless auth config is in place.
Note: For some reason, we were getting errors in our GHA after repeatedly trying to rerun, saying
Error: google-github-actions/auth failed with: the GitHub Action workflow must specify exactly one of "workload_identity_provider" or "credentials_json"!. However, the env vars mentioned were already set so we're not sure what might have caused this. If it happens again, try pushing up an empty commit to see if the GHA correctly builds again.