Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Census Individual Page Titles - ENG/WLS #161

Merged
merged 3 commits into from
Sep 17, 2020

Conversation

MebinAbraham
Copy link
Contributor

@MebinAbraham MebinAbraham commented Sep 16, 2020

What is the context of this PR?

Updates the page title for Census Individual schemas. (Eng/Wls)

How to review

Ensure:

  • titles matches what is documented in Google sheets.
  • no titles were missed.

Note:

  • Final summary was skipped as custom page title is not supported and it is agreed that is not an issue.
  • - Census 2021 is missing from the page title due to a known bug.

Checklist

Quick Launch

England

@@ -63,6 +63,7 @@ local proxyTitle = {
{
type: 'Question',
id: 'mixed-or-multiple-ethnic-group',
page_title: 'Mixed or Multiple ethnic group or background',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should Multiple be capitalised?

Copy link
Contributor Author

@MebinAbraham MebinAbraham Sep 17, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They are as per google sheet. I have already sent the quick launch to Donna and Laura to double-check.

Copy link
Contributor

@JamesGardiner JamesGardiner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Schema changes are good. Content needs to be checked by Donna/Laura

@MebinAbraham MebinAbraham merged commit d4fb94e into master Sep 17, 2020
@MebinAbraham MebinAbraham deleted the update-ci-page-titles branch September 17, 2020 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants