Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds response_expires_at claim parser and validator #715

Merged
merged 18 commits into from
Nov 19, 2021
Merged

Adds response_expires_at claim parser and validator #715

merged 18 commits into from
Nov 19, 2021

Conversation

jamesnunn
Copy link
Contributor

@jamesnunn jamesnunn commented Nov 15, 2021 •
edited
Loading

What is the context of this PR?

Adds support for the presence of an optional JWT claim for response_expires_at, the format for the datetime being defined here

See also ONSdigital/eq-questionnaire-launcher#34

How to review

Check unit tests defined to ensure the claim is correctly interrogated.

Checklist

  • New static content marked up for translation
  • Newly defined schema content included in eq-translations repo

@jamesnunn jamesnunn marked this pull request as ready for review November 16, 2021 11:38
@jamesnunn jamesnunn changed the title adds response expiry parser, validator Adds response_expiry_at parser and validator Nov 16, 2021
@jamesnunn jamesnunn changed the title Adds response_expiry_at parser and validator Adds response_expires_at claim parser and validator Nov 16, 2021
@jamesnunn jamesnunn mentioned this pull request Nov 16, 2021
Merged
@jamesnunn
Copy link
Contributor Author

Runner to accept response_expires_at launch claim (2 SP)

MebinAbraham
MebinAbraham reviewed Nov 17, 2021
View reviewed changes
app/utilities/metadata_parser.py Outdated Show resolved Hide resolved
tests/app/parser/test_metadata_parser.py Outdated Show resolved Hide resolved
tests/app/parser/conftest.py Outdated Show resolved Hide resolved
parimooa
parimooa approved these changes Nov 18, 2021
View reviewed changes
Copy link
Contributor

@parimooa parimooa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jamesnunn jamesnunn mentioned this pull request Nov 18, 2021
Merged
2 tasks
MebinAbraham
MebinAbraham reviewed Nov 18, 2021
View reviewed changes
app/utilities/metadata_parser.py Outdated Show resolved Hide resolved
tests/app/parser/test_metadata_parser.py Outdated Show resolved Hide resolved
@jamesnunn jamesnunn merged commit 5f0f167 into master Nov 19, 2021
@jamesnunn jamesnunn deleted the add-response-expiry branch November 19, 2021 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MebinAbraham MebinAbraham MebinAbraham approved these changes

@parimooa parimooa parimooa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jamesnunn @parimooa @MebinAbraham