Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter list summaries on unrelated question blocks #348

Merged

Conversation

ajmaddaford
Copy link
Contributor

What is the context of this PR?

Filters list summaries on unrelated question blocks so that they only include people after the current person.

How to review

  • Use the test_relationships_unrelated schema and add some people
  • Note down some of the list item ids
  • Use list item ids in the related-to-anyone-else url and check that the page only displays peoples names after the current person - the url format is questionnaire/relationships/people/{list_item_id}/related-to-anyone-else.

Note that if you use the last list item id in the related-to-anyone-else url it will display all people. I did consider handling this in some way, but decided not to, as this won't be possible when the unrelated routing feature is done (the location won't be routable).

Checklist

  • [-] New static content marked up for translation
  • [-] Newly defined schema content included in eq-translations repo

Copy link
Contributor

@MebinAbraham MebinAbraham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feature is as expected, just a minor comment.

app/views/handlers/relationships/unrelated_question.py Outdated Show resolved Hide resolved
app/views/contexts/list_context.py Outdated Show resolved Hide resolved
List summaries on unrelated question blocks now only include
people after the current person.
@ajmaddaford ajmaddaford force-pushed the filter-list-summaries-on-unrelated-question-blocks branch from a78843c to 14b1cdc Compare October 14, 2020 13:38
@ajmaddaford ajmaddaford merged commit 36275c0 into master Oct 14, 2020
@ajmaddaford ajmaddaford deleted the filter-list-summaries-on-unrelated-question-blocks branch October 14, 2020 13:50
@pricem14pc pricem14pc added this to the v3.51.0 milestone Oct 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants