Add initial support for unrelated relationship

[MebinAbraham]

What is the context of this PR?

Added the initial support unrelated relationship block.

The scope of this PR is just to add the initial screen with not specific functionality however there are quite a few places that doesn't work/haven't been accounted for as it does not impact this piece of work. For example the following are not correct:

• previous location
• next location
• Location object serialisation

A lot of concepts haven't really been thought about and may reveal issues when implementing more of the functionality. Also, it might make sense to extend this piece to support more of the feature so that this is a bit more complete and makes more sense.

How to review

• Is the page accessible manually
• Is the content of the page correct?

Checklist

• New static content marked up for translation
• Newly defined schema content included in eq-translations repo

[ajmaddaford]

There should also be a check that the list name matches the for_list of the parent. I think otherwise in a schema with more than one list, it would be possible to use the unrelated page with the wrong list?

[ajmaddaford]

The test names could be made shorter without losing any clarity by removing relationship_unrelated / unrelated_relationship (as all of the tests in this class are testing unrelated relationships).

[LJBabbage]

Husband or wife, or unrelated, what a question? I get the extra page and it looks good structurally, my only query is why if I use my list_item_id, I am giving an option to say I am related to myself, should it not be removed? The only other point is the url change, that we check that its ok.

[MebinAbraham]

Husband or wife, or unrelated, what a question? I get the extra page and it looks good structurally, my only query is why if I use my list_item_id, I am giving an option to say I am related to myself, should it not be removed? The only other point is the url change, that we check that its ok.

@LJBabbage

This card doesn't cover filtering of the list_summary as specified by the Trello card. This will simply list all householders. There is a card to filter the list_summary to only show the relevant people.

As for the URL, it was done after a discussion with @ajmaddaford. I did also bring it with the tech session as it makes things easier to deal with. But ultimately it was changed because the location object has a list_name attribute which is used by classes under inheritance so it made sense that the attribute to actually be part of the URL also.

[LJBabbage]

This card doesn't cover filtering of the list_summary as specified by the Trello card. This will simply list all householders. There is a card to filter the list_summary to only show the relevant people.

As for the URL, it was done after a discussion with @ajmaddaford. I did also bring it with the tech session as it makes things easier to deal with. But ultimately it was changed because the location object has a list_name attribute which is used by classes under inheritance so it made sense that the attribute to actually be part of the URL also.

mmm, the filter according to the card is "to filter those who have not had a relationship established" its not quite the same

[MebinAbraham]

This card doesn't cover filtering of the list_summary as specified by the Trello card. This will simply list all householders. There is a card to filter the list_summary to only show the relevant people.
As for the URL, it was done after a discussion with @ajmaddaford. I did also bring it with the tech session as it makes things easier to deal with. But ultimately it was changed because the location object has a list_name attribute which is used by classes under inheritance so it made sense that the attribute to actually be part of the URL also.

mmm, the filter according to the card is "to filter those who have not had a relationship established" its not quite the same

Correct but it requires modifying how list_summary works, which is covered by https://trello.com/c/QNwNR874/4171-u-filter-list-summary-on-related-to-anyone-screen-m

- First iteration to use/display complete (unfiltered) `"list_summary": { "for_list": "household"`
- Subsequent card to allow a `filter` of the list_summary (to filter those who have not had a relationship established)

Have added a small comment to the filter card to filter out the current list item.

[LJBabbage]

Not a problem, the original card just didn't say that