Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set gunicorn worker class via CLI #332

Merged
merged 1 commit into from
Oct 5, 2020

Conversation

MebinAbraham
Copy link
Contributor

@MebinAbraham MebinAbraham commented Oct 5, 2020

What is the context of this PR?

Due to the order of the env vars, when using new relic, the run commands was incorrect. To solve this, I have set the gunicorn worker class via the CLI. If this is not preferred, I can push a change to make use of an additional vars in shell script to manage the ordering.

Using gunicorn-async:
Before:

NEW_RELIC_CONFIG_FILE=newrelic.ini newrelic-admin run-program WEB_SERVER_WORKER_CLASS=gevent gunicorn application:application

After:

NEW_RELIC_CONFIG_FILE=newrelic.ini newrelic-admin run-program gunicorn application:application --worker-class gevent

How to review

Set EQ_NEW_RELIC_ENABLED=True in .development.env and ensure the app can be started up under different web servers.

Checklist

  • New static content marked up for translation
  • Newly defined schema content included in eq-translations repo

@MebinAbraham MebinAbraham merged commit b4c089a into master Oct 5, 2020
@MebinAbraham MebinAbraham deleted the set-gunicorn-worker-class-via-cli branch October 5, 2020 15:03
@pricem14pc pricem14pc added this to the v3.50.0 milestone Oct 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants