Add IR failure template and handle failure #324
Conversation
…l/eq-questionnaire-runner into individual-response-error-page
| return ( | ||
| render_template("errors/individual_response", retry_url=retry_url), | ||
| 500, | ||
| ) |
There was a problem hiding this comment.
I think we need to decide a consistent approach for rendering error pages on exceptions. In #318 this is handled in errors.py.
There was a problem hiding this comment.
I actually prefer the approach in #318 - it's at the least consistent with what we currently do
| try: | ||
| self._publish_fulfilment_request() | ||
| except PublicationFailed: | ||
| retry_url = url_for( | ||
| "individual_response.individual_response_post_address_confirm", | ||
| list_item_id=self._list_item_id, | ||
| **self._request_args, | ||
| ) | ||
| return ( | ||
| render_template("errors/individual_response", retry_url=retry_url), | ||
| 500, | ||
| ) |
There was a problem hiding this comment.
If the try except was moved into _publish_fulfilment_request you could avoid the duplication in the handle_post for mobile and post. You can work out the retry URL from the fact that you have a mobile number etc. Then, the method name might then be more appropriate as handle_fulfiilment_request or similar.
There was a problem hiding this comment.
not sure about handle_fulfiilment_request - I think I prefer handle_fulfilment_request 😛
There was a problem hiding this comment.
Actually, this gets uglier when you consider the handle_post then has to check the return value of the fulfilment request method to determine if it has failed or not - in this instance I think it is better to be explicit
There was a problem hiding this comment.
It doesn't if you are going to redirect to the new page on the exception?
There was a problem hiding this comment.
This disappears in any case if I follow the approach in #318, as I can handle the logic in the registered error handler.
I'm making this change now btw, so let me know what you prefer when I make the push
There was a problem hiding this comment.
Updated in f18f331 - I've created a new Exception class, FulfilmentRequestFailedException, to handle this apart from generic PubSub PublicationFailed errors.
…l/eq-questionnaire-runner into individual-response-error-page
…l/eq-questionnaire-runner into individual-response-error-page
tests/integration/individual_response/test_individual_response.py
Outdated
Show resolved
Hide resolved
Co-authored-by: Andrew Maddaford <[email protected]>
What is the context of this PR?
Handles individual response publish failures by returning the individual response error template using a 500 error code.